Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index-codecs.md #7837

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

sandervandegeijn
Copy link
Contributor

@sandervandegeijn sandervandegeijn commented Jul 25, 2024

qat_deflate does not work on 2.14, it does on 2.15.

2.14:

{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
}
],
"type": "illegal_argument_exception",
"reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
},
"status": 400
}

2.15:
{
"acknowledged": true,
"shards_acknowledged": true,
"index": "x"
}

Description

Issues Resolved

Version

2.14+

Frontend features

Checklist

  • [*] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@sarthakaggarwal97
Copy link
Contributor

+1 to this. The feature was not release in 2.14.
Thanks @sandervandegeijn

@hdhalter
Copy link
Contributor

Actually, @sandervandegeijn, we need to update this line too:

As of OpenSearch 2.14, hardware-accelerated compression codecs for the DEFLATE and LZ4 compression algorithms are available. These hardware-accelerated codecs are available on the latest 4th and 5th Gen Intel®️ Xeon®️ processors running Linux kernel 3.10 and later. For all other systems and platforms, the codecs use that platform's corresponding software implementations.

Can you please make that change?

@sandervandegeijn
Copy link
Contributor Author

Updated everything to 2.15!

@hdhalter
Copy link
Contributor

Hi, @sandervandegeijn, can you please fix DCO? Thanks!

qat_deflate does not work on 2.14, it does on 2.15.

2.14:

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
  },
  "status": 400
}

2.15:
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "index": "x"
}

Signed-off-by: Sander van de Geijn <[email protected]>
Signed-off-by: Sander van de Geijn <[email protected]>
@sandervandegeijn
Copy link
Contributor Author

Done!

@hdhalter hdhalter merged commit f58bf56 into opensearch-project:main Jul 30, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
* Update index-codecs.md

qat_deflate does not work on 2.14, it does on 2.15.

2.14:

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
  },
  "status": 400
}

2.15:
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "index": "x"
}

Signed-off-by: Sander van de Geijn <[email protected]>

* Update to 2.15 for all.

Signed-off-by: Sander van de Geijn <[email protected]>

---------

Signed-off-by: Sander van de Geijn <[email protected]>
(cherry picked from commit f58bf56)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
mingshl pushed a commit to mingshl/documentation-website that referenced this pull request Aug 2, 2024
* Update index-codecs.md

qat_deflate does not work on 2.14, it does on 2.15.

2.14:

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "unknown value for [index.codec] must be one of [default, lz4, best_compression, zlib] but was: qat_deflate"
  },
  "status": 400
}

2.15:
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "index": "x"
}

Signed-off-by: Sander van de Geijn <[email protected]>

* Update to 2.15 for all.

Signed-off-by: Sander van de Geijn <[email protected]>

---------

Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants