Add predefined model interface doc #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
hdhalter
added
3 - Tech review
natebower
reviewed
Jul 26, 2024
There was a problem hiding this comment.
@kolchfa-aws @b4sjoo Please see my comments and changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
hdhalter
added
5 - Editorial review
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
approved these changes
Jul 30, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
approved these changes
Jul 30, 2024
hdhalter
added
3 - Done
mingshl
pushed a commit
to mingshl/documentation-website
that referenced
this pull request
Aug 2, 2024
* Add predefined model interface doc Signed-off-by: Sicheng Song <[email protected]> * Update _ml-commons-plugin/api/model-apis/register-model.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Update _ml-commons-plugin/api/model-apis/register-model.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Update _ml-commons-plugin/api/model-apis/register-model.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Update _ml-commons-plugin/api/model-apis/register-model.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Update _ml-commons-plugin/api/model-apis/register-model.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Address comments Signed-off-by: Sicheng Song <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should add draft doc for predefined model interface
Issues Resolved
Closes #7793
Version
2.16
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.