Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for neural-sparse-query-two-phase-processor. #7306
Add doc for neural-sparse-query-two-phase-processor. #7306
Changes from 1 commit
b188880
7a0df87
22d4739
d11c412
33a7c6e
e1fd8dd
074f340
61f74ee
d05dc86
d5f068b
7f4b04f
5fa2306
0442dd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 266 in _search-plugins/neural-sparse-search.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we give some example API calling like the section
## Setting a default model on an index or field
? Using all default values is also good, this would help users a lotThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also mention that this processor is strongly recommended to set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave a example API for set a default 2-phase pipeline.
Add a explanation for why we recommend this pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine-tune is usually used for ML models, maybe we should use rescore here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with word rescore.
Check failure on line 30 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 67 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 71 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 72 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 79 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 81 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 82 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
Check failure on line 97 in _search-plugins/search-pipelines/neural-sparse-query-two-phase-processor.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this sparse_vector search or end to end latency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also depending on the index configuration and two-phase parameters
Do you mean this depends on the dataset distribution? Because I think we're using default two-phase parameters and consistent index settings in our experimentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i corrected the description to index specific data distribution and dataset size .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the speed up ratio on pure sparse vector is more important. The model inference cost and retrieval cost is orthogonal and the 2-phase pipeline only optimize the retrieval cost.