Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for DocumentDB as a source. #7137
Adds documentation for DocumentDB as a source. #7137
Changes from 1 commit
79d3f43
e444d3a
c82878e
a5d9d8a
fc88eda
f59c570
8c9b630
dd1130d
960f6ce
b8372f6
d19bfb7
f7e120e
ed6daae
7d76a74
bc33f53
134c4af
bf743ab
cbb33f1
666752c
79dc780
797ad86
c8da4bb
b78c736
78d551c
176dfa7
a350940
a66cc1c
9e7e8fb
07c6f25
df48ebc
6abf7bd
4e3e546
69102ee
dd10324
cd27480
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 9 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
Check failure on line 9 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Amazon DocumentDB always requires "Amazon" to precede it, and AWS does not capitalize "change streams". Also, rather than "keep up to date", would "stay current with the data" work?
Check failure on line 14 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
Check failure on line 14 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
Check failure on line 48 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
Check failure on line 49 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
Check failure on line 55 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Determines the method used to read from Amazon DocumentDB"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli , I took a different approach here. I found the clearest way to communicate this was to leave the order as it is. I made some changes in my latest revision which include the word "instead" to try to clarify that one configuration is better than the other.
Check failure on line 65 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that this and the following headings are intentionally lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the configuration settings proper name. I'll set in code format for clarity.
Check failure on line 75 in _data-prepper/pipelines/configuration/sources/documentdb.md
GitHub Actions / style-job