adding a get started with security page #6668 #7128
Conversation
Signed-off-by: AntonEliatra <[email protected]>
|
Thanks, @AntonEliatra ! Looks great. Can you please address the Vale errors? In the meantime, I'm checking on the location with @kolchfa-aws. |
hdhalter
added
2 - In progress
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
|
@hdhalter Great thanks, Vale errors are fixed now |
…earch-project#2359 Signed-off-by: AntonEliatra <[email protected]>
…-project#6668 Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
@hdhalter this is now ready for review |
hdhalter
added
3 - Tech review
|
Thanks, @AntonEliatra ! @scrawfor99 - can you please give this a review? Is there anyone else that you think should take a look? Thanks. |
|
Thanks, @scrawfor99 ! @DarshitChanpura , can you please review this since it has a section on setting up the security config demo? |
There was a problem hiding this comment.
Hi @AntonEliatra thank you for raising this PR.
Left some suggestions for changes. We should also mention the already existing setup doc for using demo configuration: https://opensearch.org/docs/latest/security/configuration/demo-configuration/ since that talks in depth about how to set-up security using demo configuration.
Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
There was a problem hiding this comment.
LGTM @AntonEliatra ! Thank you for addressing the comments. There are a couple of minor vale errors around styling. Please take a look at those once you get a chance.
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
hdhalter
added
4 - Doc review
Signed-off-by: AntonEliatra <[email protected]>
|
@DarshitChanpura Thanks for the review, I've added reference to existing documentation, regarding the Vale error, I'm not sure how to reference a name of external too without raising a vale error |
@AntonEliatra @DarshitChanpura You can ignore the Vale error. It's just flagging it because it's not in the dictionary. Thanks! |
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
@Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!
_getting-started/security.md
Outdated
| ``` | ||
| {% include copy.html %} | ||
|
|
||
| ## Uploading the configuration to security index |
There was a problem hiding this comment.
Either "a" or "the" should precede "security index".
_getting-started/security.md
Outdated
|
|
||
| ## Uploading the configuration to security index | ||
|
|
||
| The final step in configuring users, roles and any other security configuration is uploading it to OpenSearch security index. Only updating the files, without uploading them, will not change any configuration inside the already running OpenSearch cluster. |
There was a problem hiding this comment.
Either "a" or "the" should precede "OpenSearch security index".
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
* adding a get started with security page #6668 Signed-off-by: AntonEliatra <[email protected]> * fixing vale errors #6668 Signed-off-by: AntonEliatra <[email protected]> * fixing vale errors #6668 Signed-off-by: AntonEliatra <[email protected]> * adding role configurations for users without kibanauser mapping #2359 Signed-off-by: AntonEliatra <[email protected]> * updating the page layout for getting started with security #6668 Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * adding additional details to getting started with security Signed-off-by: AntonEliatra <[email protected]> * adding additional details to getting started with security Signed-off-by: AntonEliatra <[email protected]> * Update security.md Signed-off-by: AntonEliatra <[email protected]> * Update security.md Signed-off-by: AntonEliatra <[email protected]> * adding link for existing docs for demo config Signed-off-by: AntonEliatra <[email protected]> * Doc review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit f912f9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adding "Getting started with OpenSearch security" page
Issues Resolved
Closes #6668
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.