-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add index.search.default_pipeline setting #7103
feat: add index.search.default_pipeline setting #7103
Conversation
Signed-off-by: Ian Menendez <[email protected]>
Thanks for adding this, @IanMenendez ! @msfroh - Can you please check this for technical accuracy? |
- `index.search.default_pipeline` (String): The default search pipeline for the index to be used on each search request. If the default pipeline is set and the pipeline does not exist, then index requests fail. The pipeline name _none specifies that the index does not have an search pipeline. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to incorporate the changes (and the limitations) from https://github.com/opensearch-project/documentation-website/pull/7053/files too.
Prior to OpenSearch 2.14, index.search.default_pipeline
would only work if you search exactly 1 index using its name. If you tried to us an index pattern, an alias, or multiple indices, then no default pipeline would be applied.
With the linked change, we resolve index names, aliases, patterns to the real indices, check to see which default search pipelines they use (if any). If all resolved indices use the same pipeline, we'll use it. Otherwise, we still won't apply a search pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we link to the updated topic in https://opensearch.org/docs/latest/search-plugins/search-pipelines/using-search-pipeline/#default-search-pipeline once 2.14 is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we link to the updated topic in https://opensearch.org/docs/latest/search-plugins/search-pipelines/using-search-pipeline/#default-search-pipeline once 2.14 is merged?
I like this idea. As this new changes will make the text way more lengthy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfroh - Can you please review my rewrite? If we are only pointing to the section, we could actually publish this change anytime without waiting for 2.14.
_install-and-configure/configuring-opensearch/index-settings.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Heather Halter <[email protected]>
* feat: add index.search.default_pipeline setting Signed-off-by: Ian Menendez <[email protected]> * Update _install-and-configure/configuring-opensearch/index-settings.md Signed-off-by: Heather Halter <[email protected]> --------- Signed-off-by: Ian Menendez <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Heather Halter <[email protected]> (cherry picked from commit d065bd5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add Information on
index.search.default_pipeline
under_install-and-configure/configuring-opensearch/index-settings.md
Issues Resolved
Closes #7102
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.