-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin and Super Admin (security admin) Documentation Update #7069
Admin and Super Admin (security admin) Documentation Update #7069
Conversation
@leanneeliatra - Is this ready for review? |
Hi @hdhalter it is still in progress at the moment, I will be adding some updates to this section of the docs today. Thanks a million. |
This ticket is now ready for review. cc @hdhalter |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Apologies if I missed that last capitalisation link @hdhalter. All changes now integrated! Thanks. |
@Naarcha-AWS - Can you please take a final look at this? An editorial request has been submitted. Thanks! |
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leanneeliatra @Naarcha-AWS Please see my comments and changes and tag me for approval on lines 265 and 274 in users-roles.md and 131 and 138 in security-admin.md. Thanks!
|
||
#### Authentication of super admin role | ||
|
||
Super admins are authenticated through certificates, not passwords. The necessary certificates are defined in the `admin_dn` section of the `opensearch.yml` file and must be signed with the same root CA to verify and connect it to the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this end in a colon? What is being shown in the following example?
_security/configuration/tls.md
Outdated
@@ -128,14 +128,16 @@ If your node certificates have an Object ID (OID) identifier in the SAN section, | |||
|
|||
## Configuring admin certificates | |||
|
|||
Admin certificates are regular client certificates that have elevated rights to perform administrative tasks. You need an admin certificate to change the Security plugin configuration using [`plugins/opensearch-security/tools/securityadmin.sh`]({{site.url}}{{site.baseurl}}/security/configuration/security-admin/) or the REST API. Admin certificates are configured in `opensearch.yml` by stating their DN(s): | |||
Super admin certificates are regular client certificates that have elevated rights to perform administrative security and OpenSearch related tasks. You need an admin certificate to change the Security plugin configuration using [`plugins/opensearch-security/tools/securityadmin.sh`]({{site.url}}{{site.baseurl}}/security/configuration/security-admin/) or the REST API. Super admin certificates are configured in `opensearch.yml` by stating their DN(s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"security and OpenSearch related tasks" is too vague and doesn't work here. Please revise for clarity.
_security/configuration/tls.md
Outdated
|
||
```yml | ||
plugins.security.authcz.admin_dn: | ||
- CN=admin,OU=SSL,O=Test,L=Test,C=DE | ||
``` | ||
|
||
For security reasons, you can't use wildcards or regular expressions here. | ||
For security reasons, you cannot use wildcards or regular expressions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace "here" with a more precise expression.
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS LGTM with one minor change. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
* adding information about the admin and security admin roles Signed-off-by: [email protected] <[email protected]> * reviewdog fixes Signed-off-by: [email protected] <[email protected]> * updating admin priveleges documentation Signed-off-by: [email protected] <[email protected]> * admin and super admin documentation added and made clearer Signed-off-by: [email protected] <[email protected]> * review dog signoff Signed-off-by: [email protected] <[email protected]> * removing extra space Signed-off-by: [email protected] <[email protected]> * added further clarification for superAdmin certs Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * reviewdog address Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * calling out super admin where appropriate Signed-off-by: [email protected] <[email protected]> * capitalise linked reference Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 7dd0961) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The addition of supporting documentation to describe the Administration roles and their purposes in OpenSearch. This documentation update will cover the Admin and Super admin role in OpenSearch.
Issues Resolved
Closes [DOC]Add documentation to clarify differences between admin and super admin roles #4646
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.