Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin and Super Admin (security admin) Documentation Update #7069

Conversation

leanneeliatra
Copy link
Contributor

@leanneeliatra leanneeliatra commented May 1, 2024

Description

The addition of supporting documentation to describe the Administration roles and their purposes in OpenSearch. This documentation update will cover the Admin and Super admin role in OpenSearch.

Issues Resolved

Closes [DOC]Add documentation to clarify differences between admin and super admin roles #4646

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter hdhalter added security 2 - In progress Issue/PR: The issue or PR is in progress. backport 2.13 PR: Backport label for 2.13 labels May 1, 2024
@hdhalter
Copy link
Contributor

hdhalter commented May 7, 2024

@leanneeliatra - Is this ready for review?

@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented May 8, 2024

@leanneeliatra - Is this ready for review?

Hi @hdhalter it is still in progress at the moment, I will be adding some updates to this section of the docs today. Thanks a million.

@leanneeliatra leanneeliatra changed the title [DRAFT] Adding information about the admin and security admin roles Admin and Super Admin (security admin) Documentation Update May 15, 2024
@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented May 15, 2024

This ticket is now ready for review. cc @hdhalter

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels May 15, 2024
@leanneeliatra
Copy link
Contributor Author

Apologies if I missed that last capitalisation link @hdhalter. All changes now integrated! Thanks.

@hdhalter
Copy link
Contributor

@Naarcha-AWS - Can you please take a final look at this? An editorial request has been submitted. Thanks!

@hdhalter hdhalter assigned Naarcha-AWS and unassigned hdhalter May 28, 2024
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jun 4, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @Naarcha-AWS Please see my comments and changes and tag me for approval on lines 265 and 274 in users-roles.md and 131 and 138 in security-admin.md. Thanks!

_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved
_security/access-control/users-roles.md Outdated Show resolved Hide resolved

#### Authentication of super admin role

Super admins are authenticated through certificates, not passwords. The necessary certificates are defined in the `admin_dn` section of the `opensearch.yml` file and must be signed with the same root CA to verify and connect it to the cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this end in a colon? What is being shown in the following example?

@@ -128,14 +128,16 @@ If your node certificates have an Object ID (OID) identifier in the SAN section,

## Configuring admin certificates

Admin certificates are regular client certificates that have elevated rights to perform administrative tasks. You need an admin certificate to change the Security plugin configuration using [`plugins/opensearch-security/tools/securityadmin.sh`]({{site.url}}{{site.baseurl}}/security/configuration/security-admin/) or the REST API. Admin certificates are configured in `opensearch.yml` by stating their DN(s):
Super admin certificates are regular client certificates that have elevated rights to perform administrative security and OpenSearch related tasks. You need an admin certificate to change the Security plugin configuration using [`plugins/opensearch-security/tools/securityadmin.sh`]({{site.url}}{{site.baseurl}}/security/configuration/security-admin/) or the REST API. Super admin certificates are configured in `opensearch.yml` by stating their DN(s):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"security and OpenSearch related tasks" is too vague and doesn't work here. Please revise for clarity.


```yml
plugins.security.authcz.admin_dn:
- CN=admin,OU=SSL,O=Test,L=Test,C=DE
```

For security reasons, you can't use wildcards or regular expressions here.
For security reasons, you cannot use wildcards or regular expressions here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace "here" with a more precise expression.

_security/configuration/tls.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS requested a review from natebower June 5, 2024 16:45
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS LGTM with one minor change. Thanks!

_security/configuration/tls.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit 7dd0961 into opensearch-project:main Jun 5, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 5, 2024
* adding information about the admin and security admin roles

Signed-off-by: [email protected] <[email protected]>

* reviewdog fixes

Signed-off-by: [email protected] <[email protected]>

* updating admin priveleges documentation

Signed-off-by: [email protected] <[email protected]>

* admin and super admin documentation added and made clearer

Signed-off-by: [email protected] <[email protected]>

* review dog signoff

Signed-off-by: [email protected] <[email protected]>

* removing extra space

Signed-off-by: [email protected] <[email protected]>

* added further clarification for superAdmin certs

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* reviewdog address

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* calling out super admin where appropriate

Signed-off-by: [email protected] <[email protected]>

* capitalise linked reference

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 7dd0961)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.14 PR: Backport label for 2.14 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]Add documentation to clarify differences between admin and super admin roles
6 participants