Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for printing associated queries, and sample documents in notification message. #6866
Added documentation for printing associated queries, and sample documents in notification message. #6866
Changes from 3 commits
98767e6
1d6baf4
65a6e2c
c479700
db177e8
a2ae72f
220d17a
6561e38
40f3722
964ee98
dd6a436
0a59b93
4f60bbc
2fdffae
1983713
c697d19
2ce26c0
cf0f740
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Alerts that have been triggered" => "Triggered alerts"? "creating endless numbers of the same alert" => "perpetually creating the same alert"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm technical meaning is retained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for documentation reviewers:
The following sentence on line 146, calls out that the variable names for the "alerts" list is
newAlerts
for per bucket monitors, andalerts
for per document monitors.The example in this code block is for a per document monitor as, on line 188, the "alerts" list is accessed via
{{#ctx.alerts}}
instead of{{#ctx.newAlerts}}
. Does that seem clear enough, or would it be helpful to update the note on line 184 to call out that the example is for a per document monitor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets update line 184 and call it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised.