-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: index param in async search #6816
Merged
Naarcha-AWS
merged 5 commits into
opensearch-project:main
from
IanMenendez:async-search-index-param
Apr 2, 2024
Merged
feat: index param in async search #6816
Naarcha-AWS
merged 5 commits into
opensearch-project:main
from
IanMenendez:async-search-index-param
Apr 2, 2024
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMenendez
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
March 31, 2024 22:34
Signed-off-by: Ian Menendez <[email protected]>
IanMenendez
force-pushed
the
async-search-index-param
branch
from
April 1, 2024 15:21
7f4e18e
to
85f9c0f
Compare
Naarcha-AWS
requested changes
Apr 2, 2024
_search-plugins/async/index.md
Outdated
@@ -31,6 +31,7 @@ Options | Description | Default value | Required | |||
`wait_for_completion_timeout` | The amount of time that you plan to wait for the results. You can see whatever results you get within this time just like in a normal search. You can poll the remaining results based on an ID. The maximum value is 300 seconds. | 1 second | No | |||
`keep_on_completion` | Whether you want to save the results in the cluster after the search is complete. You can examine the stored results at a later time. | `false` | No | |||
`keep_alive` | The amount of time that the result is saved in the cluster. For example, `2d` means that the results are stored in the cluster for 48 hours. The saved search results are deleted after this period or if the search is canceled. Note that this includes the query execution time. If the query overruns this time, the process cancels this query automatically. | 12 hours | No | |||
`index` | The name of the index to be searched, or a comma-separated list or wildcard expression of index names. | searches on all cluster indexes | No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
`index` | The name of the index to be searched, or a comma-separated list or wildcard expression of index names. | searches on all cluster indexes | No | |
`index` | The name of the index to be searched. Can be an individual name, a comma-separated list of indexes, or a wildcard expression of index names. | All indexes in the cluster | No |
Naarcha-AWS
added
4 - Doc review
PR: Doc review in progress
backport 2.12
PR: Backport label for 2.12
labels
Apr 2, 2024
Signed-off-by: Ian Menendez <[email protected]>
andrross
approved these changes
Apr 2, 2024
Naarcha-AWS
approved these changes
Apr 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* feat: index param in async search Signed-off-by: Ian Menendez <[email protected]> * feat: requested changes Signed-off-by: Ian Menendez <[email protected]> --------- Signed-off-by: Ian Menendez <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 9f35e93) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Apr 2, 2024
* feat: index param in async search * feat: requested changes --------- (cherry picked from commit 9f35e93) Signed-off-by: Ian Menendez <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Closes #6812
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.