Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default Model Id for Neural Sparse Search Query in neural_query_enricher #6725

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented Mar 20, 2024

Description

Update the documents about supporting default model_id in neural_sparse query clause.

Issues Resolved

Closes #6652

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
@zhichao-aws zhichao-aws marked this pull request as ready for review March 20, 2024 02:49
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.13.0 labels Mar 20, 2024
Signed-off-by: zhichao-aws <[email protected]>
@hdhalter hdhalter changed the title Default Model Id for Neural Sparse Search Query in neural_query_enricher Add Default Model Id for Neural Sparse Search Query in neural_query_enricher Mar 20, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @zhichao-aws!

@kolchfa-aws
Copy link
Collaborator

This does not require an editorial review because the text is copied from the semantic search page. Merging now.

@kolchfa-aws kolchfa-aws merged commit aa1aeee into opensearch-project:main Mar 20, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Mar 20, 2024
CaptainDredge pushed a commit to CaptainDredge/documentation-website that referenced this pull request Mar 22, 2024
…nricher (opensearch-project#6725)

* modify description

Signed-off-by: zhichao-aws <[email protected]>

* remove unneed update

Signed-off-by: zhichao-aws <[email protected]>

* update neural-sparse-search

Signed-off-by: zhichao-aws <[email protected]>

* update neural-sparse-search

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Default Model Id for Neural Sparse Search Query clause
3 participants