Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force-merge API supports primary_only parameter #6664

Merged
merged 9 commits into from
Mar 21, 2024

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Mar 13, 2024

Description

Add primary_only parameter to the document of force-merge API.

Issues Resolved

Closes #6662

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
@gaobinlong
Copy link
Contributor Author

Hi @hdhalter @vagimeli , this PR is ready for review, please help to review, thank you!

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong Doc review complete. Please review the changes to confirm they retain technical accuracy. Thank you.

_api-reference/index-apis/force-merge.md Outdated Show resolved Hide resolved
_api-reference/index-apis/force-merge.md Outdated Show resolved Hide resolved
@hdhalter hdhalter changed the title Force-merge API supports primary_only parameter Add force-merge API supports primary_only parameter Mar 18, 2024
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong Thanks for making the changes. Doc review complete. I've moved this to editorial. Once the editor reviews, I'll address that feedback and then merge the PR. Thank you, @vagimeli

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Mar 20, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong @vagimeli Just a couple minor changes. Thanks!

_api-reference/index-apis/force-merge.md Outdated Show resolved Hide resolved
@vagimeli vagimeli merged commit 1235990 into opensearch-project:main Mar 21, 2024
3 checks passed
@vagimeli vagimeli added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Mar 21, 2024
hdhalter pushed a commit that referenced this pull request Mar 21, 2024
* Force-merge API supports primary_only parameter

Signed-off-by: gaobinlong <[email protected]>

* Fix typo

Signed-off-by: gaobinlong <[email protected]>

* Fix typo

Signed-off-by: gaobinlong <[email protected]>

* Fix vale failure

Signed-off-by: gaobinlong <[email protected]>

* Refine the wording

Signed-off-by: gaobinlong <[email protected]>

* Update _api-reference/index-apis/force-merge.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
CaptainDredge pushed a commit to CaptainDredge/documentation-website that referenced this pull request Mar 22, 2024
…ct#6664)

* Force-merge API supports primary_only parameter

Signed-off-by: gaobinlong <[email protected]>

* Fix typo

Signed-off-by: gaobinlong <[email protected]>

* Fix typo

Signed-off-by: gaobinlong <[email protected]>

* Fix vale failure

Signed-off-by: gaobinlong <[email protected]>

* Refine the wording

Signed-off-by: gaobinlong <[email protected]>

* Update _api-reference/index-apis/force-merge.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Force-merge API supports primary_only parameter
4 participants