-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force-merge API supports primary_only parameter #6664
Conversation
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong Doc review complete. Please review the changes to confirm they retain technical accuracy. Thank you.
Signed-off-by: gaobinlong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong Thanks for making the changes. Doc review complete. I've moved this to editorial. Once the editor reviews, I'll address that feedback and then merge the PR. Thank you, @vagimeli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong @vagimeli Just a couple minor changes. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
* Force-merge API supports primary_only parameter Signed-off-by: gaobinlong <[email protected]> * Fix typo Signed-off-by: gaobinlong <[email protected]> * Fix typo Signed-off-by: gaobinlong <[email protected]> * Fix vale failure Signed-off-by: gaobinlong <[email protected]> * Refine the wording Signed-off-by: gaobinlong <[email protected]> * Update _api-reference/index-apis/force-merge.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
…ct#6664) * Force-merge API supports primary_only parameter Signed-off-by: gaobinlong <[email protected]> * Fix typo Signed-off-by: gaobinlong <[email protected]> * Fix typo Signed-off-by: gaobinlong <[email protected]> * Fix vale failure Signed-off-by: gaobinlong <[email protected]> * Refine the wording Signed-off-by: gaobinlong <[email protected]> * Update _api-reference/index-apis/force-merge.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Add
primary_only
parameter to the document of force-merge API.Issues Resolved
Closes #6662
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.