Add aggregations to Search-Hybrid search section #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
force-pushed
the
aggregations_for_hybrid_query
branch
2 times, most recently
from
480f60a to
6d1b3e6
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
aggregations_for_hybrid_query
branch
from
6d1b3e6 to
d21b410
Compare
martin-gaievski
changed the title
martin-gaievski
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
stephen-crawford
as code owners
4 tasks
hdhalter
added
4 - Doc review
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thanks so much for providing this documentation, @martin-gaievski! The doc review is complete. I'll take the PR from here through editorial review.
hdhalter
changed the title
natebower
reviewed
Mar 20, 2024
There was a problem hiding this comment.
@martin-gaievski @kolchfa-aws Just a few minor changes. Thanks!
_search-plugins/hybrid-search.md
Outdated
|
|
||
| Most aggregations are performed on the subset of documents that is returned by a hybrid query. The only aggregation that operates on all documents is the [`global`]({{site.url}}{{site.baseurl}}/aggregations/bucket/global/) aggregation. | ||
|
|
||
| To illustrate how aggregations can be used with hybrid query, first let's create an index. Aggregations are typically used on fields of special types, like `keyword` or `integer`. The following example creates an index with several such fields: |
There was a problem hiding this comment.
Can we remove or replace "let's"?
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
CaptainDredge
pushed a commit
to CaptainDredge/documentation-website
that referenced
this pull request
Mar 22, 2024
…6661) * Changing hybrid search section, adding info about aggregations Signed-off-by: Martin Gaievski <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
hdhalter
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend section for Hybrid search by adding information and examples for aggregations.
Issues Resolved
Closes #6644
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.