Deprecate max_token_score in neural sparse search #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
stephen-crawford
as code owners
|
This PR should be backported to 2.12 and 2.x branch. |
kolchfa-aws
approved these changes
Mar 1, 2024
Signed-off-by: kolchfa-aws <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* deprecated max_token_score Signed-off-by: zhichao-aws <[email protected]> * Update _query-dsl/specialized/neural-sparse.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 5f486ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
added a commit
that referenced
this pull request
Mar 1, 2024
* deprecated max_token_score * Update _query-dsl/specialized/neural-sparse.md --------- (cherry picked from commit 5f486ab) Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: kolchfa-aws <[email protected]>
oeyh
pushed a commit
to oeyh/documentation-website
that referenced
this pull request
Mar 14, 2024
…#6554) * deprecated max_token_score Signed-off-by: zhichao-aws <[email protected]> * Update _query-dsl/specialized/neural-sparse.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
max_token_scorefield in neural sparse search was deprecated in 2.12 release. (ref PR). To avoid causing confusion for users, we should also update the information in documentation.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.