Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent framework/throttling/hidden model/OS assistant and update conversational search documentation #6354
Add agent framework/throttling/hidden model/OS assistant and update conversational search documentation #6354
Changes from 8 commits
2102d08
b50da8c
45963b0
0382604
7f4499b
56c148c
00d53a9
afc9ac6
36bf022
7583223
92e2af7
16943ed
6185c1d
3f61951
ba3983f
70eab78
e7671b8
eaf1f46
c8d7c3c
76833f7
9044eaf
1a0e818
8369db2
31d7690
efeaca4
3881fb0
8d9b2fe
544456d
bf49d69
96343b2
33b3d2b
c3ecb48
9cced21
aaba606
de47bf9
01ab264
bb7e0a3
e78a542
a28e5d8
31beeb9
0ccdc7f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to Amazon Bedrock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"returns" instead of "sends back"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define k-NN, or are we treating it as commonly understood?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can link to it but I think it's commonly understood.
Check warning on line 205 in _ml-commons-plugin/agents-tools/agents-tools-tutorial.md
GitHub Actions / vale
[vale] _ml-commons-plugin/agents-tools/agents-tools-tutorial.md#L205
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last sentence, could "for vector search" be removed? That sentence is a bit lengthy.