-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Change the "master" nomenclature #450
Closed
Labels
enhancement
New feature or request
good first issue
Good for newcomers
upcoming release
Don't merge until the version or feature is available
v2.0.0
Milestone
Comments
tlfeng
added
enhancement
New feature or request
untriaged
upcoming release
Don't merge until the version or feature is available
v2.0.0
labels
Mar 15, 2022
Thanks @tlfeng! We'll get this in before the upcoming preview. |
5 tasks
20 tasks
4 tasks
12 tasks
dblock
changed the title
[FEATURE] Change the "master" nomenclature
[FEATURE] Deprecate the "master" nomenclature
Apr 18, 2022
alicejw1
added a commit
to alicejw1/documentation-website
that referenced
this issue
Apr 18, 2022
alicejw1
added a commit
to alicejw1/documentation-website
that referenced
this issue
Apr 18, 2022
Signed-off-by: alicejw <[email protected]>
1 task
4 tasks
1 task
1 task
tlfeng
changed the title
[FEATURE] Deprecate the "master" nomenclature
[FEATURE] Change the "master" nomenclature
Apr 22, 2022
Reopening to change the |
Boxing this back up post merge of #1151. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
upcoming release
Don't merge until the version or feature is available
v2.0.0
Is your feature request related to a problem?
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472 (comment), with the plan for its terminology replacement.
The existing OpenSearch REST APIs and settings will be deprecated in version 2.0, and eventually be removed in at least version 3.0. Please prepare for the nomenclature change in advance.
What solution would you like?
Replace the terminology "master" with "cluster manager".
The impact to the OpenSearch user of the nomenclature change:
For detailed code change, please see the issue opensearch-project/OpenSearch#1549.
List of REST API and setting changes:
For all the non-inclusive REST APIs and settings list, please see the replacement plan of master terminology for OpenSearch repository: opensearch-project/OpenSearch#472 (comment)
Setting names
1
cluster.initial_master_nodes
(static)New name:
cluster.initial_cluster_manager_nodes
2
cluster.no_master_block
(dynamic)New name:
cluster.no_cluster_manager_block
3
cluster.service.slow_master_task_logging_threshold
(dynamic)New name:
cluster.service.slow_cluster_manager_task_logging_threshold
Expected behavior (same as the deprecated OpenDistro settings of plugins):
Setting value
1 node.roles: [ master ]
New name of the
master
role :cluster_manager
master
role. New node created by OpenSearch 2.0 will havecluster_manager
role and withoutmaster
role by default, but they have got the same functionality.["cluster_manager","data","ingest"]
, instead of["master","data","ingest"]
master
role andcluster_manager
role can not be assigned together to a node.REST API endpoint
1
GET _cat/master
New name:
GET _cat/cluster_manager
_cat/master
and new path_cat/cluster_manager
will get the same response.REST API path parameter
1 "node filters" used in some cluster-level APIs. The APIs are usually in the format: GET /_nodes/<node_id>, where <node_id> can be set as
_master
ormaster:true
ormaster:false
to filter the master nodes.cluster_manager
can also be used to filter nodes to be shown in the API response. Besides,master
andcluster_manager
have got the same filtering effect, and they will filter the node with either role.REST API request parameter name
1
master_timeout
=New name:
cluster_manager_timeout
=cluster_manager_timeout
will be added, and it has the same effect with the existingmaster_timeout
. An exception will be thrown if values are assigned to the both parameters.REST API request parameter value
1 metric=
master_node
New name: metric=
cluster_manager_node
master_node
orcluster_manager_node
can get the same metrics.metric
parameter is used inGET /_cluster/state/<metrics>/<target>
andPOST /_cluster/reroute
APIsREST API response field
1
discovered_master
in the response of GET _cluster/healthNew name: discovered_cluster_manager
discovered_cluster_manager
, though the "old" fielddiscovered_master
has not been added to the document yet.2
discovered_master
in the response of GET _cat/healthdiscovered_master
of the table in the response of GET _cat/health API will be replaced bydiscovered_cluster_manager
(breaking change)master
, please useh
parameter to filter the column to be shown explicitly, such asGET _cat/health?v&h=master
3
master
in the response of GET _cat/nodesmaster -> cluster_manager
master
of the table in the response of GET _cat/nodes API will be replaced bycluster_manager
(breaking change)master
, please useh
parameter to filter the column to be shown explicitly, such asGET _cat/nodes?v&h=version,master
What alternatives have you considered?
none.
Do you have any additional context?
none.
The text was updated successfully, but these errors were encountered: