Make acknowledgment_timeout configurable for s3 scan source, configure timeout to 10 minutes for MongoDB L2 transform #4988
+22
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dinujoh
reviewed
Sep 30, 2024
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| public class S3SourceConfig { | |||
| static final Duration DEFAULT_BUFFER_TIMEOUT = Duration.ofSeconds(10); | |||
| static final Duration DEFAULT_ACKNOWLEDGMENT_TIMEOUT = Duration.ofSeconds(10); | |||
There was a problem hiding this comment.
It is not used. Will remove
dinujoh
previously approved these changes
Sep 30, 2024
…e timeout to 10 minutes for MongoDB L2 transform Signed-off-by: Taylor Gray <[email protected]>
oeyh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is some reason that causes partition for s3 scan to not be given up, or if the acknowledgment is never received for a partition, s3 scan defaults to a 2 hour acknowledgment wait before reprocessing. For mongodb pipelines, this can cause high delay for some records, and these pipelines are meant to be low latency.
This change adds an
acknowledgment_timeoutparameter to S3 scan, and sets it to 10 minutes in the DocumentDB L2 transform.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.