Fixes Jaeger Hotrod demo failure on OpenSearch 2.16.0 #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Sep 10, 2024
linghengqian
commented
Sep 11, 2024
There was a problem hiding this comment.
Is there a way to view Gradle's standard output on the log of Github Actions, like ASF Develocity? I am confused why is failed download log of https://github.com/opensearch-project/data-prepper/actions/runs/10756318242/job/29955010383#step:4:1 .
dlvenable
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you @linghengqian for this improvement! I have a few small comments and questions.
Signed-off-by: linghengqian <[email protected]>
linghengqian
force-pushed
the
fix-example
branch
from
a9d9cb0 to
b4a45fa
Compare
dlvenable
approved these changes
Sep 12, 2024
|
Thank you @linghengqian for this contribution. This will help the community know how to use Data Prepper tracing with newer versions of OpenSearch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
adminas the default password for theadminaccount, which is very dangerous. The new version of OpenSearch corrects this problem and requires the initial password to be greater than 8 digits.versionfield is deprecated. The Compose Spec is now dynamically updated at https://github.com/compose-spec/compose-spec .../demo/root-ca.pemis exactly the same as the content of/usr/share/opensearch/config/root-ca.pemof the OpenSearch master node. Whether in the new version or the old version, there is no point in manually writingroot-ca.pem, which will only confuse users.../demo/demo-data-prepper.crtto/etc/demo-data-prepper.crtdoes not make any sense because SSL is turned off for otel-collector and data-prepper.node-0.example.comis actually the defaulthostnamefor OpenSearch Docker Image, which surprised me. I don't understand why this is done.🤔adminandopensearchNode1Testaccounts and passwords to log in tolocalhost:5601for testing.Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.