Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cache on any 401 response errors #1634

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Clear cache on any 401 response errors #1634

merged 2 commits into from
Mar 26, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 26, 2024 •
edited
Loading

Description

Clear cache on any 401 response errors

Issues Resolved

#1484

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48
fixes clear cache on 401/403
c53aa45 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 added the bug Something isn't working label Mar 26, 2024
@ps48
remove 403 check
38d7f92 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 changed the title Clear cache on any 401/403 response errors Clear cache on any 401 response errors Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.97%. Comparing base (48646fd) to head (c53aa45).
Report is 1 commits behind head on 2.13.

❗ Current head c53aa45 differs from pull request most recent head 38d7f92. Consider uploading reports for the commit 38d7f92 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             2.13    #1634   +/-   ##
=======================================
  Coverage   57.97%   57.97%           
=======================================
  Files         365      365           
  Lines       13712    13712           
  Branches     3610     3610           
=======================================
  Hits         7949     7949           
  Misses       5700     5700           
  Partials       63       63
Flag Coverage Δ
dashboards-observability 57.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit ce4d69f into opensearch-project:2.13 Mar 26, 2024
14 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
@github-actions
Clear cache on any 401 response errors (#1634)
31e73f9 
* fixes clear cache on 401/403

Signed-off-by: Shenoy Pratik <[email protected]>

* remove 403 check

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit ce4d69f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 26, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
@github-actions
Clear cache on any 401 response errors (#1634)
679bded 
* fixes clear cache on 401/403

Signed-off-by: Shenoy Pratik <[email protected]>

* remove 403 check

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit ce4d69f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 26, 2024
Merged
ps48 pushed a commit that referenced this pull request Mar 28, 2024
@opensearch-trigger-bot @github-actions
Clear cache on any 401 response errors (#1634) (#1635)
29ff502 
* fixes clear cache on 401/403



* remove 403 check



---------


(cherry picked from commit ce4d69f)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 28, 2024
@opensearch-trigger-bot @github-actions
Clear cache on any 401 response errors (#1634) (#1636)
3f02819 
* fixes clear cache on 401/403



* remove 403 check



---------


(cherry picked from commit ce4d69f)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@ps48
Clear cache on any 401 response errors (opensearch-project#1634)
a407b21 
* fixes clear cache on 401/403

Signed-off-by: Shenoy Pratik <[email protected]>

* remove 403 check

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit ce4d69f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@Swiddis Swiddis Swiddis approved these changes

@paulstn paulstn paulstn approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport main backport 2.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps48 @paulstn @Swiddis @sejli