Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add datasource field in accelerations cache #1526

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b0f0d9b from #1525.

* add datasource in accelerations cache

Signed-off-by: Shenoy Pratik <[email protected]>

* fixed nits

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit b0f0d9b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.22%. Comparing base (04e824d) to head (dd3164f).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
public/framework/catalog_cache/cache_loader.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1526      +/-   ##
==========================================
+ Coverage   56.89%   57.22%   +0.32%     
==========================================
  Files         346      346              
  Lines       12457    12476      +19     
  Branches     3165     3169       +4     
==========================================
+ Hits         7088     7139      +51     
+ Misses       5316     5284      -32     
  Partials       53       53              
Flag Coverage Δ
dashboards-observability 57.22% <95.83%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 added the enhancement New feature or request label Mar 13, 2024
@ps48 ps48 merged commit 2d18a4f into 2.x Mar 13, 2024
24 of 34 checks passed
@github-actions github-actions bot deleted the backport/backport-1525-to-2.x branch March 13, 2024 03:06
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…opensearch-project#1526)

* add datasource in accelerations cache

* fixed nits

---------

(cherry picked from commit b0f0d9b)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 2d18a4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants