Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Fit and Finish UX Fixes Pt 2. #275

Merged
merged 5 commits into from
Sep 20, 2024
Merged

[Backport 2.17] Fit and Finish UX Fixes Pt 2. #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c79af95
Fit and Finish UX Fixes Pt 2. (#270)
github-actions[bot] Sep 18, 2024
e35b0ea
Update dashboards-notifications-test-and-build-workflow.yml
AWSHurneyt Sep 18, 2024
c56d070
Update dashboards-notifications-test-and-build-workflow-prod-docker-l…
AWSHurneyt Sep 18, 2024
a2f736e
Merge branch '2.17' into backport/backport-270-to-2.17
AWSHurneyt Sep 19, 2024
ec20382
Merge branch '2.17' into backport/backport-270-to-2.17
AWSHurneyt Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions public/pages/Channels/__tests__/__snapshots__/ChannelControls.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ exports[`<ChannelControls /> spec renders the component 1`] = `
</button>
</div>
</div>
</div>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiFilterGroup"
>
<div
class="euiPopover euiPopover--anchorDownCenter"
>
Expand Down
8 changes: 8 additions & 0 deletions public/pages/Channels/__tests__/__snapshots__/Channels.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,14 @@ exports[`<Channels/> spec renders the empty component 1`] = `
</button>
</div>
</div>
</div>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiFilterGroup"
>
<div
class="euiPopover euiPopover--anchorDownCenter"
>
Expand Down
4 changes: 4 additions & 0 deletions public/pages/Channels/components/ChannelControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ export const ChannelControls = (props: ChannelControlsProps) => {
);
})}
</EuiPopover>
</EuiFilterGroup>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiFilterGroup>
<EuiPopover
button={
<EuiSmallFilterButton
Expand Down
10 changes: 8 additions & 2 deletions public/pages/Emails/__tests__/__snapshots__/SendersTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ exports[`<SendersTable /> spec renders empty state 1`] = `
class="euiPopover__anchor"
>
<button
class="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--small euiFilterButton euiFilterButton--hasIcon euiFilterButton--noGrow"
class="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--small euiFilterButton euiFilterButton-hasNotification euiFilterButton--hasIcon euiFilterButton--noGrow"
type="button"
>
<span
Expand All @@ -181,7 +181,7 @@ exports[`<SendersTable /> spec renders empty state 1`] = `
/>
</svg>
<span
class="euiButtonEmpty__text"
class="euiButtonEmpty__text euiFilterButton__text-hasNotification"
>
<span
class="euiFilterButton__textShift"
Expand All @@ -190,6 +190,12 @@ exports[`<SendersTable /> spec renders empty state 1`] = `
>
Encryption method
</span>
<span
aria-label="0 available filters"
class="euiNotificationBadge euiNotificationBadge--medium euiNotificationBadge--subdued euiFilterButton__notification"
>
0
</span>
</span>
</span>
</button>
Expand Down
10 changes: 8 additions & 2 deletions public/pages/Emails/__tests__/__snapshots__/SendersTableControls.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`<SendersTableControls /> spec renders the component 1`] = `
class="euiPopover__anchor"
>
<button
class="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--small euiFilterButton euiFilterButton--hasIcon euiFilterButton--noGrow"
class="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--small euiFilterButton euiFilterButton-hasNotification euiFilterButton--hasIcon euiFilterButton--noGrow"
type="button"
>
<span
Expand All @@ -78,7 +78,7 @@ exports[`<SendersTableControls /> spec renders the component 1`] = `
/>
</svg>
<span
class="euiButtonEmpty__text"
class="euiButtonEmpty__text euiFilterButton__text-hasNotification"
>
<span
class="euiFilterButton__textShift"
Expand All @@ -87,6 +87,12 @@ exports[`<SendersTableControls /> spec renders the component 1`] = `
>
Encryption method
</span>
<span
aria-label="0 available filters"
class="euiNotificationBadge euiNotificationBadge--medium euiNotificationBadge--subdued euiFilterButton__notification"
>
0
</span>
</span>
</span>
</button>
Expand Down
3 changes: 3 additions & 0 deletions public/pages/Emails/components/tables/SendersTableControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ export const SendersTableControls = (props: SendersTableControlsProps) => {
<EuiPopover
button={
<EuiSmallFilterButton
numFilters={
encryptionItems.filter((item) => item.checked === 'on').length
}
iconType="arrowDown"
grow={false}
onClick={() =>
Expand Down
8 changes: 8 additions & 0 deletions public/pages/Main/__tests__/__snapshots__/Main.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,14 @@ exports[`<Main /> spec renders the component 1`] = `
</button>
</div>
</div>
</div>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<div
class="euiFilterGroup"
>
<div
class="euiPopover euiPopover--anchorDownCenter"
>
Expand Down
Loading