Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use smaller and compressed varients of buttons and form components #238

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a5066a9 from #231.

@AMoo-Miki
Copy link
Contributor

@AMoo-Miki
Copy link
Contributor

Plugin "notificationsDashboards" is only compatible with OpenSearch Dashboards version "2.16.0", but used OpenSearch Dashboards version is "2.17.0"

When this PR was raised, the version of the plugin was still on 2.16.0 but since then it has been bumped. Maybe updating branch on the PR will get it past that.

)

* Use EuiSmallButton

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonEmpty

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedFormRow

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedField*

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSelect and EuiCompressedSuperSelect

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedRadio and EuiCompressedRadioGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedEuiTextArea

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedComboBox

Signed-off-by: Miki <[email protected]>

* Use EuiSmallFilterButton

Signed-off-by: Miki <[email protected]>

* Update snapshots and tests

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
(cherry picked from commit a5066a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-231-to-2.x branch from a3b3d7a to 3ebc8f3 Compare August 20, 2024 00:04
@SuZhou-Joe
Copy link
Member

CI all failed because of version mismatch but I suppose it should pass as we see them pass in the original PR.

@Hailong-am
Copy link
Collaborator

notification backend version has been bumped to 2.17, let's wait for re-run result

@Hailong-am Hailong-am merged commit f03ecac into 2.x Aug 20, 2024
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants