-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CI flow on windows main #145
Fix: CI flow on windows main #145
Conversation
Signed-off-by: SuZhou-Joe <[email protected]>
a2b2fcf
to
19be78f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 360 360
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-145-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 15c0b72ac44919d691dc459fc61d1f6d6983318c
# Push it to GitHub
git push --set-upstream origin backport/backport-145-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x Then, create a pull request where the |
* feat: remove useless step Signed-off-by: SuZhou-Joe <[email protected]> * feat: add opensearch logs Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add more requestTimeout Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 15c0b72)
* Fix: CI flow on windows main (#145) * feat: remove useless step Signed-off-by: SuZhou-Joe <[email protected]> * feat: add opensearch logs Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add more requestTimeout Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 15c0b72) * feat: add missing step Signed-off-by: SuZhou-Joe <[email protected]> * feat: add variable NOTIFICATIONS_PLUGIN_VERSION Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove upload opensearch.log Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.