Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replaced wrongly formatted mock Slack URLs with properly formatted mock Slack URLs #143

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[Backport 2.x] Replaced wrongly formatted mock Slack URLs with properly formatted mock Slack URLs #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cypress/fixtures/test_slack_channel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"config_type": "slack",
"is_enabled": true,
"slack": {
"url": "https://sample-slack-webhook"
"url": "https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2"
}
}
}
2 changes: 1 addition & 1 deletion .cypress/integration/channels.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('Test create channels', () => {

cy.get('[placeholder="Enter channel name"]').type('Test slack channel');
cy.get('[data-test-subj="create-channel-slack-webhook-input"]').type(
'https://sample-slack-webhook'
'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2'
);
cy.wait(delay);
cy.get('[data-test-subj="create-channel-send-test-message-button"]').click({
Expand Down
2 changes: 1 addition & 1 deletion public/pages/Channels/__tests__/__snapshots__/ChannelSettingsDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ exports[`<ChannelSettingsDetails /> spec renders Slack channel 1`] = `
<dd
class="euiDescriptionList__description"
>
https://chimehook
https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2
</dd>
</dl>
</div>
Expand Down
2 changes: 1 addition & 1 deletion test/mocks/mockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const mockSlack: ChannelItemType = {
config_type: 'slack',
is_enabled: false,
slack: {
url: 'https://chimehook',
url: 'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2',
},
config_id: 'test-slack',
created_time_ms: 1622670451891,
Expand Down
Loading