edit as per new page header fixed

Signed-off-by: Riya Saxena <[email protected]>
opensearch-project · Sep 6, 2024 · 7362c13 · 7362c13
1 parent 9645673
commit 7362c13
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 13 deletions.
diff --git a/public/pages/CreateChannel/CreateChannel.tsx b/public/pages/CreateChannel/CreateChannel.tsx
@@ -144,15 +144,25 @@ export function CreateChannel(props: CreateChannelsProps) {
   });
 
   useEffect(() => {
-    setBreadcrumbs([ BREADCRUMBS.NOTIFICATIONS,
+    const { edit } = props;
+    const breadcrumbs = [
+      BREADCRUMBS.NOTIFICATIONS,
       BREADCRUMBS.CHANNELS,
-      props.edit ? BREADCRUMBS.EDIT_CHANNEL : BREADCRUMBS.CREATE_CHANNEL]);
-    window.scrollTo(0, 0);
+    ];
+    if (edit) {
+      if (getUseUpdatedUx()) {
+        breadcrumbs.push(BREADCRUMBS.EDIT_CHANNEL_DETAILS(name))
+      }
+      breadcrumbs.push(BREADCRUMBS.EDIT_CHANNEL)
+    } else {
+      breadcrumbs.push(BREADCRUMBS.CREATE_CHANNEL)
+     }
 
+    setBreadcrumbs(breadcrumbs);
     if (props.edit) {
       getChannel();
     }
-  }, []);
+  }, [name, getUseUpdatedUx()]);
 
   const getChannel = async () => {
     const id = props.match.params.id;

diff --git a/public/pages/Emails/CreateRecipientGroup.tsx b/public/pages/Emails/CreateRecipientGroup.tsx
@@ -66,19 +66,25 @@ export function CreateRecipientGroup(props: CreateRecipientGroupProps) {
   };
 
   useEffect(() => {
-    setBreadcrumbs([
+    const { edit } = props;
+    const breadcrumbs = [
       BREADCRUMBS.NOTIFICATIONS,
       BREADCRUMBS.EMAIL_GROUPS,
-      props.edit
-        ? BREADCRUMBS.EDIT_RECIPIENT_GROUP
-        : BREADCRUMBS.CREATE_RECIPIENT_GROUP,
-    ]);
-    window.scrollTo(0, 0);
+    ];
+    if (edit) {
+      if (getUseUpdatedUx()) {
+        breadcrumbs.push(BREADCRUMBS.EDIT_RECIPIENT_GROUP_DETAILS(name))
+      }
+      breadcrumbs.push(BREADCRUMBS.EDIT_RECIPIENT_GROUP)
+    } else {
+      breadcrumbs.push(BREADCRUMBS.CREATE_RECIPIENT_GROUP)
+    }
 
+    setBreadcrumbs(breadcrumbs);
     if (props.edit) {
       getRecipientGroup();
     }
-  }, []);
+  }, [name, getUseUpdatedUx()]);
 
   const getRecipientGroup = async () => {
     const id = props.match.params?.id;

diff --git a/public/utils/constants.ts b/public/utils/constants.ts
@@ -34,7 +34,11 @@ export const BREADCRUMBS = Object.freeze({
   CHANNELS: { text: 'Channels', href: `#${ROUTES.CHANNELS}` },
   CHANNEL_DETAILS: { text: 'Channels', href: `#${ROUTES.CHANNEL_DETAILS}` },
   CREATE_CHANNEL: { text: 'Create channel', href: `#${ROUTES.CREATE_CHANNEL}` },
-  EDIT_CHANNEL: { text: 'Edit channel' },
+  EDIT_CHANNEL: { text: 'Edit channel', href: `#${ROUTES.EDIT_CHANNEL}` },
+  EDIT_CHANNEL_DETAILS: (name: string) => ({
+    text: `${name}`,
+    href: `#${ROUTES.EDIT_CHANNEL}`,
+  }),
   EMAIL_SENDERS: { text: 'Email senders', href: `#${ROUTES.EMAIL_SENDERS}` },
   EMAIL_GROUPS: { text: 'Email recipient groups', href: `#${ROUTES.EMAIL_GROUPS}` },
   CREATE_SENDER: {
@@ -51,7 +55,11 @@ export const BREADCRUMBS = Object.freeze({
     text: 'Create recipient group',
     href: `#${ROUTES.CREATE_RECIPIENT_GROUP}`,
   },
-  EDIT_RECIPIENT_GROUP: { text: 'Edit recipient group' },
+  EDIT_RECIPIENT_GROUP: { text: 'Edit recipient group', href: `#${ROUTES.EDIT_RECIPIENT_GROUP}`},
+  EDIT_RECIPIENT_GROUP_DETAILS: (name: string) => ({
+    text: `${name}`,
+    href: `#${ROUTES.EDIT_RECIPIENT_GROUP}`,
+  }),
 });
 
 export const ENCRYPTION_TYPE = Object.freeze({