Merging the customImportMap and maps layer plugin into 1 single plugin. #166
Conversation
custom_import_map/public/plugin.tsx
Outdated
| @@ -20,6 +28,39 @@ export class CustomImportMapPlugin | |||
| core: CoreSetup, | |||
| { regionMap }: AppPluginSetupDependencies | |||
| ): CustomImportMapPluginSetup { | |||
| // Register an application into the side navigation menu | |||
| core.application.register({ | |||
| id: PLUGIN_ID, | |||
There was a problem hiding this comment.
After change to customImportMap, I am not able to save map, but when I change back to maps-dashboards, it works on my local.
Also the id will determine URL path of Maps,
Example: http://localhost:5603/fol/app/customImportMap/create
custom_import_map/public/plugin.tsx
Outdated
| } from './types'; | ||
| import { PLUGIN_NAME, PLUGIN_ID, PLUGIN_NAVIGATION_BAR_TILE } from '../common'; |
There was a problem hiding this comment.
I think this is import from '../common/constants/shared'
There was a problem hiding this comment.
fixed this and I have added the export statement in the index.ts file in that folder. So we can use both ../common and ../common/constants/shared
Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-166-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c2e618950e313e72be3cbd895147432cb7de3ed
# Push it to GitHub
git push --set-upstream origin backport/backport-166-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Merging the customImportMap and maps layer plugin into 1 single plugin.
Signed-off-by: Navneet Verma [email protected]
Description
Merging the customImportMap and maps layer plugin into 1 single plugin.
Given that both the plugins are part of maps enhancements we are doing on OSD. It make sense to merge both the plugins.
Currently we have done the file merge, but we will working on the repo to abstract the files in right folders. This is the first step towards merging the plugins. Improvement GH issue: #167
This merge has the code till this commit: 6dfdcbb
Next Steps:
Issues Resolved
#95
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.