Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new partial translations for a few locales #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AMoo-Miki
Copy link

@AMoo-Miki AMoo-Miki commented Sep 19, 2024

Description

Add new partial translations for:

  • zh-TW
  • zh-CN
  • tr-TR
  • pt-PT
  • pt-BR
  • ko-KR
  • ja-JP
  • it-IT
  • id-ID
  • fr-FR
  • fr-CA
  • es-ES
  • es-419
  • de-DE

These are incomplete and the formats mimick en. Now that Intl is matured enough, we probably should drop the requirement for formats.

Check List

  • New locale: New issue has been opened in OpenSearch Dashboards for support.
  • New locale: DEVELOPER_GUIDE has been updated.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

"data.filter.filterEditor.rangeInputLabel": "Bereich",
"data.filter.filterEditor.rangeStartInputPlaceholder": "Beginn des Bereichs",
"data.filter.filterEditor.saveButtonLabel": "Speichern",
"data.filter.filterEditor.trueOptionLabel": "Richtig ",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Richtig" -> "Wahr"

"data.filter.filterEditor.editFilterValuesButtonLabel": "Filterwerte bearbeiten",
"data.filter.filterEditor.editQueryDslButtonLabel": "Als Query DSL bearbeiten",
"data.filter.filterEditor.existsOperatorOptionLabel": "existiert",
"data.filter.filterEditor.falseOptionLabel": "false ",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Falsch" if we're already translating the true label

"dashboard.howToStartWorkingOnNewDashboardEditLinkAriaLabel": "Dashboard bearbeiten",
"dashboard.howToStartWorkingOnNewDashboardEditLinkText": "Bearbeiten",
"dashboard.listing. savedObjectWarning": "Nach Titel kann nicht gefiltert werden",
"dashboard.listing.createButtonText": "Erstellen Sie",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "Erstellen"

"dashboard.listing.table.typeColumnName": "Typ",
"dashboard.panel.AddToLibrary": "Zur Bibliothek hinzufügen",
"dashboard.panel.clonedToast": "Geklonter Bereich",
"dashboard.panel.clonePanel": "Bereich Klonen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all the panel texts, "Tafel" is better than "Bereich" (similar for .removePanel.replacePanel, or "Bereichsdaten" -> "Tafelsdaten" in unableToMigratePanelData). "Bereich" just means area/sector, "Tafel" is appropriate for boards displaying charts or some types of control panels.

"dashboard.panel.unableToMigratePanelDataForSixOneZeroErrorMessage": "Bereichsdaten können nicht migriert werden, um die Abwärtskompatibilität von „6.1.0“ zu gewährleisten. Der Bereich enthält keine erwarteten Spalten- und/oder Zeilenfelder",
"dashboard.panel.unableToMigratePanelDataForSixThreeZeroErrorMessage": "Die Bereichsdaten können nicht für die Abwärtskompatibilität von „6.3.0\" migriert werden. Der Bereich enthält nicht das erwartete Feld: {key}",
"dashboard.panel.unlinkFromLibrary": "Verknüpfung mit Bibliothekselement aufheben",
"dashboard.placeholder.factory.displayName": "Platzhalter",
Copy link

@Swiddis Swiddis Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Anzeigename" (unless this is meant to say "placeholder", not sure if this is just the original text or a mistranslation of "display name")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is plain placeholder:

    return i18n.translate('dashboard.placeholder.factory.displayName', {
      defaultMessage: 'placeholder',
    });

So the capitalization is wrong too.

Copy link

@Swiddis Swiddis Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nouns are always capitalized in German, it would be a spelling error to write Platzhalter in lowercase

"dashboard.topNav.cloneModal.enterNewNameForDashboardDescription": "Bitte geben Sie einen neuen Namen für Ihr Dashboard ein.",
"dashboard.topNav.editSwitchLabel": "Bearbeiten",
"dashboard.topNav.options.hideAllPanelTitlesSwitchLabel": "Bereichstitel anzeigen",
"dashboard.topNav.options.useMarginsBetweenPanelsSwitchLabel": "Ränder zwischen den Bereichen verwenden",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Tafeln" instead of "Bereichen"

"dashboard.topNav.options.hideAllPanelTitlesSwitchLabel": "Bereichstitel anzeigen",
"dashboard.topNav.options.useMarginsBetweenPanelsSwitchLabel": "Ränder zwischen den Bereichen verwenden",
"dashboard.topNav.optionsButtonAriaLabel": "optionen",
"dashboard.topNav.optionsButtonTooltip": "optionen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Optionen" should be uppercase

@AMoo-Miki
Copy link
Author

Thanks @Swiddis. This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants