filter processors for the add processor section #524
Conversation
and change enrich data section processors based on the version. Add processor list change is out of scope of this CR. Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
kamahuan
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
There was a problem hiding this comment.
This PR seems to include a lot of duplicate changes as the ongoing PR #522. Suggest to start with addressing comments in that PR, and I think consequentially many of the changes made here can be ignored. Essentially the processors filtering can be scoped to just the reusable ProcessorsList component, and the EnrichSearchRequest/EnrichSearchResponse/EnrichData components can be left alone, as these are just pass-through components displaying the existing configured processors and do not need any filtering done on them.
| TEXT_EMBEDDING = 'text_embedding-processor', | ||
| TEXT_IMAGE_EMBEDDING = 'text_image_embedding-processor', |
There was a problem hiding this comment.
| @@ -1,25 +1,17 @@ | |||
| { | |||
| "id": "flowFrameworkDashboards", | |||
| "version": "2.19.0.0", | |||
| "opensearchDashboardsVersion": "2.19.0", | |||
| "opensearchDashboardsVersion": "2.18.0", | |||
| "navigation", | ||
| "opensearchDashboardsUtils" | ||
| ], | ||
| "requiredPlugins": ["navigation", "opensearchDashboardsUtils"], | ||
| "optionalPlugins": [ | ||
| "dataSource", | ||
| "dataSourceManagement", | ||
| "contentManagement" | ||
| ], | ||
| "supportedOSDataSourceVersions": ">=2.18.0 <4.0.0", |
There was a problem hiding this comment.
similar to comment in prev PR, let's change this to >=2.17.0 <4.0.0
| "navigation", | ||
| "opensearchDashboardsUtils" | ||
| ], | ||
| "requiredPlugins": ["navigation", "opensearchDashboardsUtils"], | ||
| "optionalPlugins": [ | ||
| "dataSource", | ||
| "dataSourceManagement", | ||
| "contentManagement" | ||
| ], | ||
| "supportedOSDataSourceVersions": ">=2.18.0 <4.0.0", |
There was a problem hiding this comment.
similar to comment in prev PR, let's change this to >=2.17.0 <4.0.0
|
|
||
| // Processor added state. Used to automatically open accordion when a new | ||
| // processor is added, assuming users want to immediately configure it. | ||
| const [processorAdded, setProcessorAdded] = useState<boolean>(false); | ||
|
|
||
| // Popover state when adding new processors | ||
| const [isPopoverOpen, setPopover] = useState(false); | ||
| const closePopover = () => { | ||
| setPopover(false); | ||
| }; | ||
|
|
||
| // Current processors state |
There was a problem hiding this comment.
prefer to leave these comments
| const [filteredCount, setFilteredCount] = useState(0); | ||
|
|
||
| return ( | ||
| <EuiFlexGroup direction="column"> | ||
| <ProcessorsTitle | ||
| title="Enhance query request" | ||
| processorCount={ | ||
| props.uiConfig.search.enrichRequest.processors?.length || 0 | ||
| } | ||
| processorCount={filteredCount} |
There was a problem hiding this comment.
Similar comments as #522; we should not have to make any changes in these files. We do not want to filter on the configured processors, only the available ones users can select to add & configure.
| } | ||
|
|
||
| /** | ||
| * Input component for enriching a search response (configuring search response processors, etc.) | ||
| */ | ||
| export function EnrichSearchResponse(props: EnrichSearchResponseProps) { | ||
| const [filteredCount, setFilteredCount] = useState(0); |
| // styling | ||
| import '../workspace/workspace-styles.scss'; | ||
| // import { getDataSourceEnabled } from '../../../services'; |
| @@ -38,6 +38,7 @@ const mockDispatch = jest.fn(); | |||
| const renderWithRouter = () => | |||
| render( | |||
| <Provider store={store}> | |||
| {/* <Router initialEntries={['/test?dataSourceId=123']}> */} | |||
There was a problem hiding this comment.
seems this is duplicate from #522, refer to any comments on that PR.
|
Closed per #537 |
Description
Filter processors for the add processor list.
Upon discussion, not matter which version we use for the backend, the search pipeline returns an empty list for now.
For the ingest pipeline, if the backend version is 2.17.0, disable the ML processor and enable neural processors. if backend version is 2.19.0, enable the ML processor and disable neural processors.
I use
text_embedding_ingest processorandtext_image_embedding_ingest_processorsas placeholders until more details are acknowledged.Issues Resolved
NONE
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.