fix: use correct router #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
saimedhi
approved these changes
Oct 30, 2024
|
Tested: screen-capture.24.webm |
|
@SuZhou-Joe thank you! Tested on old + new home page, all navigation seems to be working as expected now. Appreciate the quick help! |
ohltyler
approved these changes
Oct 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 0a4d768) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit 0a4d768) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flow framework is not using a correct router to render, it is using the router in Hash manner but renders the application with BrowserRouter, and it introduces many tricky behavior.
But as it changes the top Router, please do a thorough test to avoid regression issues. But it is a correct direction for making it right.
Issues Resolved
[List any issues this PR will resolve]
After fix
20241030180057215.mp4
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.