credentials manager initial poc #24
Conversation
Signed-off-by: Johnny On <[email protected]>
| @@ -0,0 +1,26 @@ | |||
| const path = require('path'); | |||
| const fs = require("fs"); | |||
| const CONFIG_PATH = path.join(__dirname, "config.json"); | |||
There was a problem hiding this comment.
What's this config file? Any reference in the codebase, I did a simple search, couldn't find anything.
There was a problem hiding this comment.
Not sure how to approach. By default it should be a file in src that is an empty object. However, when testing and using the app, it gets populated with access key information which I don't want to push
There was a problem hiding this comment.
OK so this file will be generated by code? I am good with that. Any reference in README or comments in code files will be helpful
src/config.js
Outdated
| function getConfig(name, configPath=CONFIG_PATH) { | ||
| let config = fs.readFileSync(configPath); | ||
| config = JSON.parse(config.toString()); | ||
| console.log('config', config); |
src/configPreload.js
Outdated
| }, | ||
| getConfig: (name) => configLibrary.getConfig(name), | ||
| setConfig: (config, callback) => configLibrary.setConfig(config, callback), | ||
|
|
src/renderer.js
Outdated
| function getActiveConfig() { | ||
| let profile = document.getElementById("profile"); | ||
| var name = profile.options[profile.selectedIndex].value; | ||
| console.log('name', name); |
There was a problem hiding this comment.
could you check similar console.log, and see if they are really necessary to remove. If it's for dev purpose, you can add some TODO comments, so people who work on this later will know and remove.
src/renderer.js
Outdated
| input.setAttribute("value", config[map.key]) | ||
| } | ||
| config = window.electron.getConfig(); | ||
| let profile = document.getElementById("profile"); |
There was a problem hiding this comment.
Np: you may want to make id as constants for reuse. See another usage at line 27
Signed-off-by: Johnny On <[email protected]>
Signed-off-by: Johnny On <[email protected]>
Signed-off-by: Johnny On <[email protected]>
Signed-off-by: Johnny On <[email protected]>
###Description
Allows users to create multiple login profiles and access keys.
Added a pop up window for handling credentials and saving new profiles.
Created an edit button that also updates config.
Changed config.json file to be able to store credentials.
###Issues resolved
#8