Feature findings enhancemnt #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
AWSHurneyt and
engechas
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
============================================
- Coverage 74.00% 73.97% -0.04%
- Complexity 890 896 +6
============================================
Files 133 133
Lines 5843 5890 +47
Branches 715 716 +1
============================================
+ Hits 4324 4357 +33
- Misses 1207 1222 +15
+ Partials 312 311 -1 ☔ View full report in Codecov by Sentry. |
Merged
5 tasks
engechas
previously approved these changes
Feb 20, 2024
engechas
reviewed
Feb 20, 2024
Comment on lines
25
to
26
| severity: String? = null, | ||
| detectionType: String? = null |
There was a problem hiding this comment.
Should these be enums? Not sure if there's a fixed list of possibilities or not
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
force-pushed
the
feature-findingsEnhancemnt
branch
from
53965a0 to
577850a
Compare
engechas
approved these changes
Mar 6, 2024
src/main/kotlin/org/opensearch/commons/alerting/action/GetFindingsRequest.kt
Show resolved
Hide resolved
AWSHurneyt
reviewed
Mar 6, 2024
src/main/kotlin/org/opensearch/commons/alerting/action/GetFindingsRequest.kt
Show resolved
Hide resolved
| monitorIds: List<String>? = null | ||
| monitorIds: List<String>? = null, | ||
| severity: String? = null, | ||
| detectionType: String? = null, |
There was a problem hiding this comment.
Similar comment here; this parameter should be named either logType, or detectorType to align with the rest of the repo. The UI refers to it as the logType (source), so I think that would be the better option; but I'd suggest going with whichever is more common in the code.
src/main/kotlin/org/opensearch/commons/alerting/action/GetFindingsRequest.kt
Show resolved
Hide resolved
AWSHurneyt
approved these changes
Mar 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
* added support for param in Finding API Signed-off-by: Riya Saxena <[email protected]> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <[email protected]> * adding addiional params findingIds, startTime and endTime Signed-off-by: Riya Saxena <[email protected]> * fix klint errors Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 892c34f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Mar 9, 2024
* added support for param in Finding API * added detectionType as param for Findings API enhancements * adding addiional params findingIds, startTime and endTime * fix klint errors --------- (cherry picked from commit 892c34f) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
* added support for param in Finding API Signed-off-by: Riya Saxena <[email protected]> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <[email protected]> * adding addiional params findingIds, startTime and endTime Signed-off-by: Riya Saxena <[email protected]> * fix klint errors Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 892c34f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Mar 11, 2024
* added support for param in Finding API * added detectionType as param for Findings API enhancements * adding addiional params findingIds, startTime and endTime * fix klint errors --------- (cherry picked from commit 892c34f) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* added support for param in Finding API Signed-off-by: Riya Saxena <[email protected]> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <[email protected]> * adding addiional params findingIds, startTime and endTime Signed-off-by: Riya Saxena <[email protected]> * fix klint errors Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 892c34f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
pushed a commit
that referenced
this pull request
Mar 15, 2024
* added support for param in Finding API * added detectionType as param for Findings API enhancements * adding addiional params findingIds, startTime and endTime * fix klint errors --------- (cherry picked from commit 892c34f) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…ect#606) * added support for param in Finding API * added detectionType as param for Findings API enhancements * adding addiional params findingIds, startTime and endTime * fix klint errors --------- (cherry picked from commit 892c34f) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Findings API Enhancements
Issues Resolved
[Issue
Alerting PR: https://github.com/opensearch-project/alerting/pull/1427/files
SA PR: https://github.com/opensearch-project/security-analytics/pull/803/files
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.