Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ODFERestTestCase to common utils #97

Open
jmazanec15 opened this issue Nov 15, 2021 · 2 comments
Open

Add ODFERestTestCase to common utils #97

jmazanec15 opened this issue Nov 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jmazanec15
Copy link
Member

Is your feature request related to a problem? Please describe.
It appears that we have several instances of ODFERestTestCase implementations across plugin repos:

  1. https://github.com/opensearch-project/k-NN/blob/main/src/test/java/org/opensearch/knn/ODFERestTestCase.java
  2. https://github.com/opensearch-project/anomaly-detection/blob/main/src/test/java/org/opensearch/ad/ODFERestTestCase.java
  3. https://github.com/opensearch-project/alerting/blob/11aafbe26189a474349d24c161ca956c044c7b63/alerting/src/test/kotlin/org/opensearch/alerting/ODFERestTestCase.kt

This base test class is meant to ensure ODFE compatibility. Each implementations seems slightly different. We had a test failure related to this case here: opensearch-project/k-NN#214. Given all of this, it appears that this class is a good candidate to move to common-utils.

@engechas
Copy link
Collaborator

Hi @jmazanec15 - is this issue still relevant with the introduction of OpenSearchRestTestCase in core?

@AWSHurneyt
Copy link
Collaborator

@jmazanec15 gently bumping this question ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants