Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common methods that plugins use in ODFERestTestCase to core's OpenSearchRestTestCase #9619

Open
cwperks opened this issue Aug 29, 2023 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test

Comments

@cwperks
Copy link
Member

cwperks commented Aug 29, 2023

There is an issue in the common-utils repo (opensearch-project/common-utils#97) to move this much-copied file from multiple plugin repos into common-utils. I am opening an issue in the core repo to discuss adding the common methods directly into the core repo in a generic way that is not tied with the security plugin. Many of the methods that are copied between plugins have to do with setting up a REST Client to make rest requests against a cluster with the security plugin installed and only accepting requests using HTTPS.

When OpenSearch uses HTTPS, REST Clients must be configured with a truststore containing the root certificate or be configured to not validate SSL (equivalent of curl's --insecure). From looking at a few plugin repos, it looks like the latter overly trustworthy approach is the most commonly used.

Potential methods that could be abstracted into core (taking methods from k-NN as an example):

@cwperks cwperks added enhancement Enhancement or improvement to existing feature or request untriaged labels Aug 29, 2023
@tlfeng tlfeng added the :test Adding or fixing a test label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test
Projects
None yet
Development

No branches or pull requests

3 participants