-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates admin credentials used in github workflow #518
Updates admin credentials used in github workflow #518
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is one change in even README.md and build.gradle as well.
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
updated all instances of admin credentials. This change should not be backported to <2.12 since the admin password changes are not required in those versions. |
Build failure seems to be unrelated:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Hi @DarshitChanpura , We needed another change which include 2.12 BWC jar to make the build pass, so we had to raise a new PR and merge the changes. Closing this PR for now. |
Sounds good @bharath-techie . The PR: #521 |
Description
This PR updates the occurrences of admin password in the github workflows. Coming from opensearch-project/security#3624, the security plugin recently introduced a change to require a custom strong password to be supplied when setting up the admin user via demo configuration.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.