Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Get namedXContentRegistry from ExtensionsRunner #725

Merged

Conversation

dbwiddis
Copy link
Member

Note: Requires SDK #244 to be merged first.

Description

Simplifies AnomalyDetectorExtension:

  • Inherits from BaseExtension to simplify extension settings and remove unneeded overrides
  • Passes its NamedXContent to the ExtensionsRunner during init, to be merged with core NamedXContent
  • Obtains the merged namedXContentRegistry from the Extensions Runner and passes it to the REST handler

Issues Resolved

SDK #208

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19
Copy link
Member

@dbwiddis looks like you have to rebase with feature/extensions to get the successful build?

@codecov-commenter
Copy link

Codecov Report

Merging #725 (19c08f1) into feature/extensions (11d094a) will decrease coverage by 0.46%.
The diff coverage is 16.41%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feature/extensions     #725      +/-   ##
========================================================
- Coverage                 53.81%   53.35%   -0.47%     
+ Complexity                 2679     2658      -21     
========================================================
  Files                       288      290       +2     
  Lines                     16004    16056      +52     
  Branches                   1703     1686      -17     
========================================================
- Hits                       8612     8566      -46     
- Misses                     6767     6872     +105     
+ Partials                    625      618       -7     
Flag Coverage Δ
plugin 53.35% <16.41%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java 0.00% <0.00%> (ø)
...main/java/org/opensearch/ad/auth/UserIdentity.java 54.78% <ø> (ø)
.../java/org/opensearch/ad/cluster/ADVersionUtil.java 80.00% <ø> (+5.00%) ⬆️
...in/java/org/opensearch/ad/model/ADTaskProfile.java 64.97% <0.00%> (ø)
.../java/org/opensearch/ad/model/AnomalyDetector.java 90.00% <ø> (ø)
...g/opensearch/ad/rest/RestCreateDetectorAction.java 0.00% <0.00%> (ø)
.../org/opensearch/ad/rest/RestGetDetectorAction.java 0.00% <0.00%> (ø)
...ensearch/ad/transport/ADCancelTaskNodeRequest.java 34.78% <ø> (ø)
...rg/opensearch/ad/transport/ADStatsNodeRequest.java 100.00% <ø> (ø)
...nsearch/ad/transport/ADTaskProfileNodeRequest.java 0.00% <ø> (ø)
... and 21 more

@dbwiddis dbwiddis merged commit fa81e2e into opensearch-project:feature/extensions Nov 18, 2022
@dbwiddis dbwiddis deleted the namedXContent branch November 18, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants