Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.2.3. #345

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 17, 2021

@dblock dblock added the v1.2.3 label Dec 17, 2021
@dblock dblock force-pushed the increment-to-1.2.3 branch 3 times, most recently from 835f9e8 to b8622cb Compare December 18, 2021 00:45
@dblock
Copy link
Member Author

dblock commented Dec 18, 2021

@ohltyler Could I have some help with this please?

@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Dec 18, 2021

Test "org.opensearch.ad.e2e.DetectionResultEvalutationIT.testDataset" is flaky, we need to fix this. Rerun CI to check if it can pass.

Run ./gradlew build successfully on desktop. But second run shows
Rule violated for class org.opensearch.ad.task.ADTaskManager: lines covered ratio is 0.74, but expected minimum is 0.75
Seems some test didn't run.

Track these in #278 and rerun CI

@codecov-commenter
Copy link

Codecov Report

Merging #345 (36344cc) into 1.2 (6109a12) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.2     #345      +/-   ##
============================================
- Coverage     76.37%   76.27%   -0.10%     
+ Complexity     3971     3966       -5     
============================================
  Files           295      295              
  Lines         17180    17180              
  Branches       1812     1812              
============================================
- Hits          13121    13104      -17     
- Misses         3236     3252      +16     
- Partials        823      824       +1     
Flag Coverage Δ
plugin 76.27% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/ad/transport/StopDetectorResponse.java 19.04% <0.00%> (-23.81%) ⬇️
...port/SearchAnomalyDetectorInfoTransportAction.java 60.00% <0.00%> (-4.45%) ⬇️
...ansport/handler/AnomalyResultBulkIndexHandler.java 67.74% <0.00%> (-3.23%) ⬇️
.../java/org/opensearch/ad/caching/PriorityCache.java 69.69% <0.00%> (-0.56%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.37% <0.00%> (-0.53%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.76% <0.00%> (ø)
...opensearch/ad/indices/AnomalyDetectionIndices.java 68.53% <0.00%> (+0.18%) ⬆️

@dblock dblock merged commit 4d45ebc into opensearch-project:1.2 Dec 18, 2021
@dblock dblock deleted the increment-to-1.2.3 branch December 18, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants