[2.x] Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join issue #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1029 +/- ##
============================================
- Coverage 79.39% 79.34% -0.05%
+ Complexity 4318 4315 -3
============================================
Files 307 307
Lines 18159 18157 -2
Branches 1909 1909
============================================
- Hits 14417 14407 -10
- Misses 2822 2828 +6
- Partials 920 922 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 12 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
|
This looks good @kaituo! Any reason why we are not making the changes to main and then backporting to 2.x and 2.10? |
The baseline version of main is 2.10. So I am not making the changes from main. |
jackiehanyang
approved these changes
Sep 8, 2023
|
@kaituo out of curiosity, should other plugins take a proactive step and upgrade the BWC test versions for 2.x from 1.1 to 1.3? Job Scheduler 2.x for instance uses 1.13.0 here in the sample job scheduler extension plugin that is used to execute BWC tests. I have not observed any recent BWC test failures though |
joshpalis
approved these changes
Sep 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…sue (#1029) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830)
jackiehanyang
pushed a commit
that referenced
this pull request
Sep 8, 2023
…sue (#1029) (#1030) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830) Co-authored-by: Kaituo Li <[email protected]>
owaiskazi19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
Resolution:
This PR also backports retry logic in #1017 to 2.x.
Testing:
./gradlew bwcTestSuite -Dtests.security.manager=falseand all tests passed.Issues Resolved
#964
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.