Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Alerting to 2.0 #357

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Upgrade Alerting to 2.0 #357

merged 3 commits into from
Mar 22, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Mar 21, 2022

Issue #, if available:
#313 - OpenSearch 2.0 Upgrade
#325 - Remove JDK 8 support
#351 - Fix issue by upgrading to 2.0
#317 - Remove mapping type
#246 - Upgrade to Gradle 7
Description of changes:

  • Build Alerting for OS 2.0
  • Security integ test fails due to this issue

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago marked this pull request as ready for review March 22, 2022 00:43
@lezzago lezzago requested a review from a team March 22, 2022 00:43
core/build.gradle Outdated Show resolved Hide resolved
alerting/build.gradle Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #357 (4fd1825) into main (120f7c4) will increase coverage by 0.15%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##               main     #357      +/-   ##
============================================
+ Coverage     79.00%   79.16%   +0.15%     
  Complexity      268      268              
============================================
  Files           176      176              
  Lines          7288     7286       -2     
  Branches       1016     1016              
============================================
+ Hits           5758     5768      +10     
+ Misses         1004      993      -11     
+ Partials        526      525       -1     
Impacted Files Coverage Δ
...rting/transport/TransportIndexDestinationAction.kt 62.09% <0.00%> (ø)
...ting/transport/TransportIndexEmailAccountAction.kt 63.90% <0.00%> (ø)
...erting/transport/TransportIndexEmailGroupAction.kt 59.80% <0.00%> (ø)
.../alerting/transport/TransportIndexMonitorAction.kt 62.44% <0.00%> (+0.29%) ⬆️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 74.41% <0.00%> (ø)
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 73.68% <100.00%> (+7.23%) ⬆️
...nsearch/alerting/core/model/ClusterMetricsInput.kt 95.36% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120f7c4...4fd1825. Read the comment docs.

@lezzago lezzago merged commit 0c5090f into opensearch-project:main Mar 22, 2022
Angie-Zhang pushed a commit to Angie-Zhang/alerting that referenced this pull request Jun 29, 2022
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Angie Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants