Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Alerting Comments system indices and Security ITs #1659

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Sep 10, 2024

Description

Adding Alerting Comments system indices to the Alerting Plugin's System Index Descriptors. Also adds Security ITs for Alerting Comments

This is a followup to #1655

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@toepkerd toepkerd changed the title Adding Alerting Comments system indices Adding Alerting Comments system indices and Security ITs Sep 26, 2024
}
}

fun `test user cannot edit someone else's comment`() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can admin edit some one else's ccomment

if yes plz add that test to verify

Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this but admin being able to edit someone else’s comments is not a very organic requirement

@AWSHurneyt AWSHurneyt merged commit d8f47a0 into opensearch-project:main Oct 2, 2024
18 of 19 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1659-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8f47a0f096a8f170e1c6424124afcba250f8682
# Push it to GitHub
git push --set-upstream origin backport-1659-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1659-to-2.x.

toepkerd added a commit to toepkerd/alerting that referenced this pull request Oct 2, 2024
…project#1659)

* Adding Alerting Comments system indices

Signed-off-by: Dennis Toepker <[email protected]>

* Add security ITs for Alerting Comments

Signed-off-by: Dennis Toepker <[email protected]>

* removed unused imports

Signed-off-by: Dennis Toepker <[email protected]>

* uncomment system index viewing IT

Signed-off-by: Dennis Toepker <[email protected]>

* uncommenting system index IT for now

Signed-off-by: Dennis Toepker <[email protected]>

* adding IT for admin editting someone else's comment

Signed-off-by: Dennis Toepker <[email protected]>

---------

Signed-off-by: Dennis Toepker <[email protected]>
Co-authored-by: Dennis Toepker <[email protected]>
(cherry picked from commit d8f47a0)
jowg-amazon pushed a commit that referenced this pull request Oct 2, 2024
* Adding Alerting Comments system indices

Signed-off-by: Dennis Toepker <[email protected]>

* Add security ITs for Alerting Comments

Signed-off-by: Dennis Toepker <[email protected]>

* removed unused imports

Signed-off-by: Dennis Toepker <[email protected]>

* uncomment system index viewing IT

Signed-off-by: Dennis Toepker <[email protected]>

* uncommenting system index IT for now

Signed-off-by: Dennis Toepker <[email protected]>

* adding IT for admin editting someone else's comment

Signed-off-by: Dennis Toepker <[email protected]>

---------

Signed-off-by: Dennis Toepker <[email protected]>
Co-authored-by: Dennis Toepker <[email protected]>
(cherry picked from commit d8f47a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants