-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pluginzippublish issue #1604
Conversation
Signed-off-by: Subhobrata Dey <[email protected]>
Can you check why are CIs failing in this? |
@goyamegh , looks like some transient issue.
|
Approving the PR but the plugins folder will still have the sample remote monitor plugin zip. Maven publishing is working as expected. |
Can you re-run to confirm the transient issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz fix failing CI for linxu builds
FYI we dont need to exclude |
@sbcd90 can you add the fix for the failing tests. Refer: https://github.com/opensearch-project/security-analytics/pull/1143/files. |
Signed-off-by: Subhobrata Dey <[email protected]>
* fix pluginzippublish issue Signed-off-by: Subhobrata Dey <[email protected]> * fix github cis for linux Signed-off-by: Subhobrata Dey <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 51203ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix pluginzippublish issue Signed-off-by: Subhobrata Dey <[email protected]> * fix github cis for linux Signed-off-by: Subhobrata Dey <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 51203ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix pluginzippublish issue * fix github cis for linux --------- (cherry picked from commit 51203ba) Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix pluginzippublish issue * fix github cis for linux --------- (cherry picked from commit 51203ba) Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix pluginzippublish issue Signed-off-by: Subhobrata Dey <[email protected]> * fix github cis for linux Signed-off-by: Subhobrata Dey <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]>
Issue #, if available:
#1599
Description of changes:
Re-enable publishing zip to staging repo.
Solves the problem
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.