Fixed monitor type checks. #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
lezzago,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
riysaxen-amzn
approved these changes
May 24, 2024
Hailong-am
reviewed
May 24, 2024
alerting/src/main/kotlin/org/opensearch/alerting/MonitorMetadataService.kt
Outdated
Show resolved
Hide resolved
5 tasks
Signed-off-by: AWSHurneyt <[email protected]>
Hailong-am
approved these changes
May 25, 2024
eirsep
approved these changes
May 31, 2024
AWSHurneyt
added a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Jun 25, 2024
* Fixed monitor type checks. Signed-off-by: AWSHurneyt <[email protected]> * Fixed monitor type checks. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Removed redundant toString calls. Signed-off-by: AWSHurneyt <[email protected]> * Fixed wildcard imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed monitor type checks following changes in PR opensearch-project/common-utils#661
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.