[Backport 2.x] Removed log entry regarding destination migration #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 48e56bf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
engechas
approved these changes
Mar 22, 2024
| @@ -45,7 +45,6 @@ class DestinationMigrationCoordinator( | |||
| } | |||
|
|
|||
| override fun clusterChanged(event: ClusterChangedEvent) { | |||
| logger.info("Detected cluster change event for destination migration") | |||
There was a problem hiding this comment.
Should this be swapped to debug instead of removed?
There was a problem hiding this comment.
We can, but it's redundant. We already have an if-else clause for each condition, which captures the required information in the log lines.
AWSHurneyt
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 48e56bf from #1356.