adding tracking_total_hits in search query for findings #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn,
rishabhmaurya,
engechas and
jowg-amazon
as code owners
engechas
approved these changes
Mar 21, 2024
AWSHurneyt
approved these changes
Mar 21, 2024
riysaxen-amzn
merged commit d7ee971
into
opensearch-project:main
15 of 18 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit d7ee971) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit d7ee971) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
added a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Riya Saxena <[email protected]>
1 task
riysaxen-amzn
added a commit
that referenced
this pull request
Mar 21, 2024
* adding tracking_total_hits in search query for findings (#1487) Signed-off-by: Riya Saxena <[email protected]> * updated the release notes Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit d7ee971) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit d7ee971) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Track_total_hits to true *
track_total_hits: truei.e if findings are more than 10,000 it will fetch the actual count. For refCheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.