Findings API Enhancements changes and integ tests fix

[riysaxen-amzn]

This is to modify the findings API enhancements done as part of issue. The pr contains:

• Moving the query building part to SA, alerting will use queryBuilder as request param in GetFindingsRequest to serve the purpose of querying on .opensearch-sap-*-findings index to generate findings.
• This PR also includes a flaky integ test for DocumentMonitorRunnerIT

CheckList:

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[eirsep]

why are we removing severity??

[riysaxen-amzn]

we don't need to change the behavior of existing Alerting Plugin API]. This was the part of prev commit which was merged.

[eirsep]

what is detectionType?
in alerting this has no meaning?

[riysaxen-amzn]

yes In alerting it has no meannig but we need to filter the SA findings based on the detectionType [threat intel or rule based], this will query on .opensearch-sap-*-findings index to do that. I'm open to other suggestions if this is wrong or if we've a better way to do this.

[eirsep]

pass querybuilder as param in findings request

[eirsep]

we aren't resolving boolQueryBuilder param?

[riysaxen-amzn]

we don't need to

[eirsep]

searchString was there from before?

[riysaxen-amzn]

yes

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1464-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba84d04d56fcbd8eb1ae0c9c35cb9fb6b432afbc
# Push it to GitHub
git push --set-upstream origin backport-1464-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1464-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1464-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba84d04d56fcbd8eb1ae0c9c35cb9fb6b432afbc
# Push it to GitHub
git push --set-upstream origin backport-1464-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1464-to-2.x.

[opensearch-trigger-bot]

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.12
# Create a new branch
git switch --create backport-1464-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba84d04d56fcbd8eb1ae0c9c35cb9fb6b432afbc
# Push it to GitHub
git push --set-upstream origin backport-1464-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-1464-to-2.12.