Changes in workflows for seg rep compatibility #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te alerts to evaluate chained alert trigger condition Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
lezzago
reviewed
Sep 5, 2023
Comment on lines
-230
to
-233
| val sr = SearchRequest(dataSources!!.alertsIndex) | ||
| sr.source().query(QueryBuilders.matchAllQuery()).size(10) | ||
| val searchResponse: SearchResponse = monitorCtx.client!!.suspendUntil { monitorCtx.client!!.search(sr, it) } | ||
| searchResponse.hits |
There was a problem hiding this comment.
Was this dev code that was accidentally left over?
lezzago
approved these changes
Sep 5, 2023
sbcd90
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In workflows, we save audit state alerts from delegate monitors.
Within the same workflow execution we execute a search request to fetch the persisted audit alerts from alerts system index.
Since RAW guarantees have changed with seg rep, we would need to search on primaries to ensure we have the latest information.
Relates to Compatibility with segment replication #974