-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching timezone from ui settings for Trigger context formatting #913
Merged
amsiglan
merged 3 commits into
opensearch-project:main
from
amsiglan:format-trigger-time-using-osd-timezone
Apr 4, 2024
Merged
Fetching timezone from ui settings for Trigger context formatting #913
amsiglan
merged 3 commits into
opensearch-project:main
from
amsiglan:format-trigger-time-using-osd-timezone
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
April 3, 2024 01:15
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 48.69% 48.71% +0.02%
==========================================
Files 236 236
Lines 6845 6848 +3
Branches 996 997 +1
==========================================
+ Hits 3333 3336 +3
Misses 3509 3509
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
approved these changes
Apr 3, 2024
riysaxen-amzn
approved these changes
Apr 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.8
# Create a new branch
git switch --create backport-913-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c13bae923cacccb0c9c6b482bb197428c7ad146
# Push it to GitHub
git push --set-upstream origin backport-913-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.8 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fetching timezone from ui settings Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0c13bae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 4, 2024
amsiglan
pushed a commit
that referenced
this pull request
Apr 30, 2024
…) (#922) * fetching timezone from ui settings * refactored code * removed unused code --------- (cherry picked from commit 0c13bae) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The time periods in the monitor trigger context are formatted using the browsers timezone and we are not respecting the timezone set by the user in the UI settings under Dashboards management. This PR fetches the setting if it exists, else uses the timezone provided by browser. If that doesn't exist then UTC timezone is used.
Issues Resolved
#839
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.