Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove last updated backported to 1.3 #808

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

kohinoor98
Copy link

@kohinoor98 kohinoor98 commented Nov 16, 2023

Description

Removed "last updated by" sections from the UI as the SearchMonitor API is no longer intended to return that info. See the issue below for more details.

I have backported for 1.3

Issues Resolved

#763

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Copy link
Collaborator

Manual backport of PR #767

kohinoor98 and others added 2 commits November 20, 2023 19:23
Signed-off-by: kohinoor98 <[email protected]>
* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)
Signed-off-by: kohinoor98 <[email protected]>
@AWSHurneyt
Copy link
Collaborator

Manual backport of PR #767

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38a7676) 56.66% compared to head (6305274) 56.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.3     #808      +/-   ##
==========================================
+ Coverage   56.66%   56.67%   +0.01%     
==========================================
  Files         198      198              
  Lines        4767     4764       -3     
  Branches      650      648       -2     
==========================================
- Hits         2701     2700       -1     
+ Misses       2064     2062       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows unit tests are flaky. Approving.

@bowenlan-amzn bowenlan-amzn merged commit 89f9dae into opensearch-project:1.3 Nov 22, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants