[Snapshot Interop] Adding more ITs for Snapshot Interoperability with… #9785

kasundra07 · 2023-09-06T00:27:05Z

… Remote Store.

Description

Adding more ITs for Snapshot Interoperability w/ Remote Store to improve test coverage.

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-09-06T00:34:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24532/
CommitID: fe56474
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-06T00:57:55Z

Compatibility status:

Checks if related components are compatible with change fe56474

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

… Remote Store. Signed-off-by: Bansi Kasundra <[email protected]>

github-actions · 2023-09-06T02:06:47Z

Compatibility status:

Checks if related components are compatible with change 08db963

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

github-actions · 2023-09-06T02:21:03Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/24534/
CommitID: 08db963

codecov · 2023-09-06T02:21:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d54d96) 71.04% compared to head (08db963) 71.18%.
Report is 634 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9785      +/-   ##
============================================
+ Coverage     71.04%   71.18%   +0.13%     
- Complexity    57821    58073     +252     
============================================
  Files          4818     4827       +9     
  Lines        273093   273539     +446     
  Branches      39811    39858      +47     
============================================
+ Hits         194028   194716     +688     
+ Misses        62762    62481     -281     
- Partials      16303    16342      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harishbhakuni · 2023-10-03T22:51:10Z

server/src/internalClusterTest/java/org/opensearch/snapshots/CloneSnapshotIT.java

+        FeatureFlagSetter.set(FeatureFlags.REMOTE_STORE);
+
+        internalCluster().startClusterManagerOnlyNode();
+        final String dataNode = internalCluster().startDataOnlyNode();
+        ensureStableCluster(2);
+        final String clusterManagerNode = internalCluster().getClusterManagerName();
+
+        final String snapshotRepoName = "snapshot-repo-name";
+        final Path snapshotRepoPath = randomRepoPath();
+        createRepository(snapshotRepoName, "mock", snapshotRepoSettingsForShallowCopy(snapshotRepoPath));
+
+        final Path remoteStoreRepoPath = randomRepoPath();
+        createRepository("remote-store-repo-name", "fs", remoteStoreRepoPath);
+
+        final String remoteStoreEnabledIndexName = "remote-index-1";
+        final Settings remoteStoreEnabledIndexSettings = getRemoteStoreBackedIndexSettings();
+        createIndex(remoteStoreEnabledIndexName, remoteStoreEnabledIndexSettings);
+        indexRandomDocs(remoteStoreEnabledIndexName, randomIntBetween(5, 10));


can you move these common lines to a different method, so that they can be reused in other tests?

harishbhakuni · 2023-10-03T22:53:37Z

server/src/internalClusterTest/java/org/opensearch/snapshots/CloneSnapshotIT.java

+     */
+    public void testShallowCloneAcquireLockFailed() throws Exception {
+        disableRepoConsistencyCheck("This test uses remote store repository");
+        FeatureFlagSetter.set(FeatureFlags.REMOTE_STORE);


we don't need this flag now as REMOTE_STORE is GA since 2.10.

opensearch-trigger-bot · 2023-11-03T15:19:55Z

This PR is stalled because it has been open for 30 days with no activity.

ticheng-aws · 2024-01-06T00:16:59Z

Hi @kasundra07, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

opensearch-trigger-bot · 2024-02-17T15:19:21Z

This PR is stalled because it has been open for 30 days with no activity.

kotwanikunal · 2024-03-14T19:46:42Z

Closing this stalled PR. Please reopen to continue with the contribution.

[Snapshot Interop] Adding more ITs for Snapshot Interoperability with…

08db963

… Remote Store. Signed-off-by: Bansi Kasundra <[email protected]>

kasundra07 force-pushed the snapshotITs branch from fe56474 to 08db963 Compare September 6, 2023 01:36

kasundra07 marked this pull request as ready for review September 6, 2023 06:49

kasundra07 requested review from sachinpkale, sohami and msfroh as code owners September 6, 2023 06:49

harishbhakuni reviewed Oct 3, 2023

View reviewed changes

opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 3, 2023

ticheng-aws added the enhancement Enhancement or improvement to existing feature or request label Jan 6, 2024

opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 9, 2024

opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Feb 17, 2024

kotwanikunal closed this Mar 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snapshot Interop] Adding more ITs for Snapshot Interoperability with… #9785

[Snapshot Interop] Adding more ITs for Snapshot Interoperability with… #9785

kasundra07 commented Sep 6, 2023 •

edited

Loading

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

codecov bot commented Sep 6, 2023 •

edited

Loading

harishbhakuni Oct 3, 2023 •

edited

Loading

harishbhakuni Oct 3, 2023

opensearch-trigger-bot bot commented Nov 3, 2023

ticheng-aws commented Jan 6, 2024

opensearch-trigger-bot bot commented Feb 17, 2024

kotwanikunal commented Mar 14, 2024

[Snapshot Interop] Adding more ITs for Snapshot Interoperability with… #9785

[Snapshot Interop] Adding more ITs for Snapshot Interoperability with… #9785

Conversation

kasundra07 commented Sep 6, 2023 • edited Loading

Description

Check List

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Sep 6, 2023 • edited Loading

Codecov Report

harishbhakuni Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

harishbhakuni Oct 3, 2023

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Nov 3, 2023

ticheng-aws commented Jan 6, 2024

opensearch-trigger-bot bot commented Feb 17, 2024

kotwanikunal commented Mar 14, 2024

kasundra07 commented Sep 6, 2023 •

edited

Loading

codecov bot commented Sep 6, 2023 •

edited

Loading

harishbhakuni Oct 3, 2023 •

edited

Loading