Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level of SegRep cancellations to debug #9445

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Aug 18, 2023

Description

Change log level of SegRep cancellations to debug. These are noisy in tests where replication is cancelled on node drop.

Related Issues

related #8452

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change bf10ff7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testShallowCloneNameAvailability
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #9445 (0c1f2c7) into main (f3957ea) will decrease coverage by 0.09%.
Report is 9 commits behind head on main.
The diff coverage is 61.53%.

@@             Coverage Diff              @@
##               main    #9445      +/-   ##
============================================
- Coverage     71.24%   71.15%   -0.09%     
+ Complexity    57472    57420      -52     
============================================
  Files          4776     4776              
  Lines        270711   270713       +2     
  Branches      39574    39574              
============================================
- Hits         192874   192638     -236     
- Misses        61610    61893     +283     
+ Partials      16227    16182      -45     
Files Changed Coverage Δ
...s/replication/SegmentReplicationTargetService.java 56.75% <61.53%> (-1.88%) ⬇️

... and 465 files with indirect coverage changes

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mch2 mch2 added the backport 2.x Backport to 2.x branch label Aug 20, 2023
@mch2 mch2 merged commit 628bbd0 into opensearch-project:main Aug 20, 2023
@mch2 mch2 deleted the logs branch August 20, 2023 21:43
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 20, 2023
Signed-off-by: Marc Handalian <[email protected]>
(cherry picked from commit 628bbd0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Aug 21, 2023
(cherry picked from commit 628bbd0)

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants