-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] org.opensearch.client.RestClientSingleHostIntegTests.testRequestResetAndAbort is flaky #9206
Conversation
…tResetAndAbort is flaky Signed-off-by: Andriy Redko <[email protected]>
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
flaky: #9116 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9206 +/- ##
============================================
+ Coverage 71.06% 71.18% +0.11%
- Complexity 57328 57413 +85
============================================
Files 4766 4768 +2
Lines 270512 270540 +28
Branches 39557 39559 +2
============================================
+ Hits 192229 192572 +343
+ Misses 62115 61782 -333
- Partials 16168 16186 +18
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9206-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d014c4d280108db78427f330c7ea1c677c22603e
# Push it to GitHub
git push --set-upstream origin backport/backport-9206-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]>
UPD: No need to backport, |
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]>
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]>
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…tResetAndAbort is flaky (opensearch-project#9206) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
The issue was caused by race between aborting the HTTP request and completing the resulting future. Added
Phaser
to predictably control the cancellation race.Related Issues
Resolves #9034
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.