[Backport] Restrict user overrides for remote store related index settings (#8812) #9025

linuxpi · 2023-08-01T15:18:27Z

Signed-off-by: Varun Bansal [email protected]
(cherry picked from commit 66ea4b3)

Description

Backports #8812

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-08-01T16:01:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21575/
CommitID: 6de4a0f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-02T05:48:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21670/
CommitID: 20aca20
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-02T12:06:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21688/
CommitID: 2b1414f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-02T12:10:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21689/
CommitID: 827f7ce
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: bansvaru <[email protected]>

…search-project#8812) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit 66ea4b3)

github-actions · 2023-08-03T08:54:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21768/
CommitID: 623fb4a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

opensearch-trigger-bot · 2023-08-03T08:58:11Z

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

BUILD SUCCESSFUL in 31m 10s

opensearch-trigger-bot · 2023-08-03T09:27:39Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 23m 59s

github-actions · 2023-08-03T09:30:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21769/
CommitID: babb80e
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: bansvaru <[email protected]>

Signed-off-by: Varun Bansal <[email protected]>

opensearch-trigger-bot · 2023-08-03T10:00:57Z

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 22m 39s

opensearch-trigger-bot · 2023-08-03T10:09:01Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 29m 29s

github-actions · 2023-08-03T10:21:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

URL: https://build.ci.opensearch.org/job/gradle-check/21772/
CommitID: 97919c5
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-08-03T10:22:34Z

Codecov Report

Merging #9025 (9c80f95) into 2.x (de5ad92) will decrease coverage by 0.11%.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##                2.x    #9025      +/-   ##
============================================
- Coverage     70.79%   70.68%   -0.11%     
+ Complexity    57386    57299      -87     
============================================
  Files          4749     4749              
  Lines        271399   271395       -4     
  Branches      40055    40050       -5     
============================================
- Hits         192132   191833     -299     
- Misses        62791    63089     +298     
+ Partials      16476    16473       -3

Files Changed	Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java	`93.18% <ø> (ø)`
...pensearch/common/settings/IndexScopedSettings.java	`100.00% <ø> (ø)`
...org/opensearch/cluster/metadata/IndexMetadata.java	`83.80% <61.53%> (-1.13%)`	⬇️
...h/cluster/metadata/MetadataCreateIndexService.java	`78.92% <100.00%> (-0.52%)`	⬇️
...in/java/org/opensearch/indices/IndicesService.java	`70.15% <100.00%> (+0.30%)`	⬆️

... and 466 files with indirect coverage changes

github-actions · 2023-08-03T10:28:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/21773/
CommitID: 9c80f95

linuxpi changed the title ~~Restrict user overrides for remote store related index settings (#8812)~~ [Backport] Restrict user overrides for remote store related index settings (#8812) Aug 1, 2023

linuxpi force-pushed the backport/backport-8812-to-2.x branch from 2b1414f to 827f7ce Compare August 2, 2023 11:22

dreamer-89 mentioned this pull request Aug 2, 2023

Restrict user overrides for remote store related index settings #8812

Merged

6 tasks

skip engine instanceOf InternalEngine assertion for closed shards

c70ba29

Signed-off-by: bansvaru <[email protected]>

linuxpi mentioned this pull request Aug 3, 2023

skip engine instanceOf InternalEngine assertion for closed shards #9084

Merged

6 tasks

Restrict user overrides for remote store related index settings (open…

c3479eb

…search-project#8812) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit 66ea4b3)

linuxpi force-pushed the backport/backport-8812-to-2.x branch from 827f7ce to 623fb4a Compare August 3, 2023 08:26

fix tests

97919c5

Signed-off-by: bansvaru <[email protected]>

linuxpi force-pushed the backport/backport-8812-to-2.x branch from babb80e to 97919c5 Compare August 3, 2023 09:37

Merge branch '2.x' into backport/backport-8812-to-2.x

9c80f95

Signed-off-by: Varun Bansal <[email protected]>

linuxpi marked this pull request as ready for review August 3, 2023 10:27

linuxpi requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock and gbbafna as code owners August 3, 2023 10:27

linuxpi requested review from setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng, VachaShah, dbwiddis, sachinpkale and sohami as code owners August 3, 2023 10:27

sachinpkale approved these changes Aug 3, 2023

View reviewed changes

sachinpkale merged commit 3fa9a08 into opensearch-project:2.x Aug 3, 2023

linuxpi deleted the backport/backport-8812-to-2.x branch August 3, 2023 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Restrict user overrides for remote store related index settings (#8812) #9025

[Backport] Restrict user overrides for remote store related index settings (#8812) #9025

linuxpi commented Aug 1, 2023 •

edited

Loading

github-actions bot commented Aug 1, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

codecov bot commented Aug 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023

[Backport] Restrict user overrides for remote store related index settings (#8812) #9025

[Backport] Restrict user overrides for remote store related index settings (#8812) #9025

Conversation

linuxpi commented Aug 1, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Aug 1, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Aug 3, 2023

opensearch-trigger-bot bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

linuxpi commented Aug 1, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading